-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - Mithril signature diffusion with a "fake Cardano network layer" #1902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
changed the title
DO NOT MERGE - POC - Mithril signature diffusion with a "fake Cardano network layer"
POC - Mithril signature diffusion with a "fake Cardano network layer"
Aug 27, 2024
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
6 times, most recently
from
August 27, 2024 14:30
a3c4fdd
to
8bcda02
Compare
jpraynaud
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 💪
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
3 times, most recently
from
September 2, 2024 14:51
656b5a8
to
e95e2fb
Compare
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
2 times, most recently
from
September 9, 2024 15:04
fb61945
to
881e3d4
Compare
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
3 times, most recently
from
September 19, 2024 13:32
62e8461
to
9f0827d
Compare
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
2 times, most recently
from
September 25, 2024 16:49
eddd6ca
to
7a47c7f
Compare
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
from
October 7, 2024 13:24
7a47c7f
to
3f99679
Compare
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
from
October 18, 2024 10:33
3f99679
to
454b1c3
Compare
And push register signature message to the available sig queue.
By wiring the messageSender in the application.
…a subtype Since it's the `Message`type that's written to peers by the `MessageSender`, not a `RegisterSignatureMessage`.
- Always remove given socket file even if it exist - Create input dir if it doesn't exist even when an argument is provided
To a dedicated module.
It listen to incoming signatures registered in a `signatures-network-node` by calling its `pull_signatures` endpoint regularly.
* Make the first `mithril-signer` use 'old' http endpoint to send single signatures * Adjusts aggregator logs to make the process more apparent * Slow down aggregator signature pulling interval so more signatures are pulled in batch * Adjust explorer `Certificates` tab list to show in card the full signed entity type instead of the immutable file number * Fix an error in aggregator when pulling signatures from the simulated network
Alenar
force-pushed
the
djo/1837/POC/multisig_diffusion_network_layer
branch
from
October 24, 2024 17:39
454b1c3
to
8c3cdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR is a proof a concept of a decentralized message queue to diffuse Mithril signatures.
Since the protocol that will be used for signature diffusion through the Cardano node is still on the design phase, we simulate it with the creation of a new binary
signature-network-node
:pull-signatures
route on the node unix socket.mithril-signer
signature registration is abstracted with a new trait,SignaturePublisher
, that have two implementations. One is the previous behavior communicating directly to the aggregator using http, the other foward signatures thought asignature-network-node
unix socket.mithril-aggregator
have a new thread that pulls signatures constantly using thepull-signatures
route of asignature-network-node
unix socket and register them using thecertifier-service
the same way as its http server does.mithil-end-to-end
have been adapted to spawn onesignature-network-node
per mithril node.Comments
🛑 DO NOT MERGE: 🛑 This PR should not be merged as it is intended for experimentation only.
As this is a POC several shortcuts were used:
signature-network-node
stores registered signatures indefinitely until theirpull-signatures
route is called, meaning it's possible to make them crash by overloading their memory.Issue(s)
Relates to #1837