split snapshotter

[Alenar]

Content

This PR makes the snapshotter code more manageable by:

• moving it to services so it's no longer uncategorized at the source route
• split the module into several files to limit amount of code to navigate and make it more cohesive.

This PR also simplify local uploaders constructors by removing their StdResult (no longer needed since #2241)

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

[github-actions]

Test Results

    4 files  ±0     52 suites  ±0   10m 23s ⏱️ -11s
1 545 tests ±0  1 545 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 801 runs  ±0  1 801 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cf2654d. ± Comparison against base commit c519913.

This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.

mithril-aggregator ‑ snapshotter::tests::can_return_full_archive_path
mithril-aggregator ‑ snapshotter::tests::can_set_temp_dir_with_str_or_string
mithril-aggregator ‑ snapshotter::tests::is_snapshot_exist_return_true_when_file_exists
mithril-aggregator ‑ snapshotter::tests::should_clean_pending_snapshot_directory_if_already_exists
mithril-aggregator ‑ snapshotter::tests::should_create_a_valid_archive_with_gzip_snapshotter
mithril-aggregator ‑ snapshotter::tests::should_create_a_valid_archive_with_zstandard_snapshotter
mithril-aggregator ‑ snapshotter::tests::should_create_directory_if_does_not_exist
mithril-aggregator ‑ snapshotter::tests::should_delete_tmp_file_in_pending_snapshot_directory_if_snapshotting_fail
mithril-aggregator ‑ snapshotter::tests::snapshot_overwrite_archive_already_existing
mithril-aggregator ‑ snapshotter::tests::snapshot_subset_return_error_when_empty_entries
…

mithril-aggregator ‑ services::snapshotter::appender::tests::snapshot_subset_return_error_when_empty_entries
mithril-aggregator ‑ services::snapshotter::appender::tests::snapshot_subset_return_error_when_file_or_directory_not_exist
mithril-aggregator ‑ services::snapshotter::appender::tests::snapshot_subset_should_create_archive_only_for_specified_directories_and_files
mithril-aggregator ‑ services::snapshotter::appender::tests::snapshot_subset_with_duplicate_files_and_directories
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::can_return_full_archive_path
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::can_set_temp_dir_with_str_or_string
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::is_snapshot_exist_return_true_when_file_exists
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::should_clean_pending_snapshot_directory_if_already_exists
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::should_create_a_valid_archive_with_gzip_snapshotter
mithril-aggregator ‑ services::snapshotter::compressed_archive_snapshotter::tests::should_create_a_valid_archive_with_zstandard_snapshotter
…

♻️ This comment has been updated with latest results.

[sfauvel]

LGTM
Just one remark on the file that contain tests for TarAppender

[jpraynaud]

LGTM 👍