Skip to content

Not depend on serde #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Not depend on serde #230

wants to merge 3 commits into from

Conversation

iquerejeta
Copy link
Contributor

Removed panics from from_bytes() functions, and removed dependency on SERDE. Now the code uses from/to_bytes instead. Trying to figure out if this solves the problem.

Removed panics from `from_bytes()` functions, and removed dependency on SERDE. Now the code uses from/to_bytes instead. Trying to figure out if this solves the problem.
@iquerejeta iquerejeta mentioned this pull request May 31, 2022
@github-actions
Copy link

github-actions bot commented May 31, 2022

Unit Test Results

    5 files  ±  0    14 suites  +3   2m 51s ⏱️ +25s
166 tests +72  166 ✔️ +72  0 💤 ±0  0 ±0 

Results for commit f06bb4b. ± Comparison against base commit d011bbb.

This pull request removes 1 and adds 73 tests. Note that renamed tests count towards both.
src/stm.rs - stm::StmSigner<D> ‑ new_epoch (line 678)
beacon_store::tests ‑ test_can_store_beacon
beacon_store::tests ‑ test_reset_current_beacon_ok
certificate_store::certificate_store::test ‑ get_certificate_with_good_hash
certificate_store::certificate_store::test ‑ get_certificate_with_wrong_hash
certificate_store::certificate_store::test ‑ list_has_some_members
certificate_store::certificate_store::test ‑ list_is_empty
certificate_store::certificate_store::test ‑ save_certificate_once
certificate_store::certificate_store::test ‑ update_certificate
certificate_store::dumb_adapter::tests ‑ test_list_with_last_zero
certificate_store::dumb_adapter::tests ‑ test_list_with_no_record
…

♻️ This comment has been updated with latest results.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@iquerejeta
Copy link
Contributor Author

Moved to #236 for testing #207 . I'm closing this.

@iquerejeta iquerejeta closed this Jun 7, 2022
@iquerejeta iquerejeta deleted the avoid_panics branch June 7, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant