fix: stm tests run time regression #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge of #2282 changed the feature set used by `mithril-client-wasm`, including the activation of the `num-integer-backed` feature from the `mithril-client` crate. With feature unification this have the side effect of enabling this slower backend for everyone when you run tests at the workspace level. Removing this feature in client wasm is no-op since `mithril-stm` enforce it when building to wasm or windows.
jpraynaud
approved these changes
Feb 13, 2025
Test Results 4 files ±0 56 suites ±0 10m 47s ⏱️ - 10m 14s Results for commit c900596. ± Comparison against base commit 6c2ecb8. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Feb 13, 2025
dlachaume
approved these changes
Feb 13, 2025
* mithril-client-wasm from `0.8.1` to `0.8.2` * [js] mithril-client-wasm from `0.8.1` to `0.8.2`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix a regression in run times of mithril-stm tests.
Merge of #2282 changed the feature set used by
mithril-client-wasm, including the activation of thenum-integer-backedfeature from themithril-clientcrate.With feature unification this have the side effect of enabling this slower backend for everyone when you run tests at the workspace level.
Removing this feature activation in client wasm is no-op since
mithril-stmenforce it when building to wasm or windows.Pre-submit checklist
Comments
Here are run times before and after this change:
Expand