-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: incremental cardano database restoration with client CLI #2318
Merged
dlachaume
merged 26 commits into
main
from
dlachaume/2246/client-cli-incremental-cardano-database-restoration
Feb 25, 2025
Merged
feat: incremental cardano database restoration with client CLI #2318
dlachaume
merged 26 commits into
main
from
dlachaume/2246/client-cli-incremental-cardano-database-restoration
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files ± 0 52 suites ±0 10m 40s ⏱️ -6s Results for commit a9c87ee. ± Comparison against base commit d7080eb. This pull request removes 10 and adds 51 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
3fcea9b
to
1a4d98a
Compare
ccc5bba
to
504fc0a
Compare
68c58fb
to
c318e5b
Compare
Base automatically changed from
jpraynaud/2214-client-library-cardano-database-restore
to
main
February 19, 2025 10:35
e618d0f
to
3ff5aa4
Compare
3ff5aa4
to
1d41bc2
Compare
35d01f7
to
329c02c
Compare
d6aa693
to
8efc964
Compare
8efc964
to
0eaf982
Compare
0eaf982
to
2ff6c05
Compare
Co-authored-by: DJO <Alenar@users.noreply.github.com>
Fetch the `CardanoDatabaseSnapshot` by its hash (or use `latest`) and verify the certificate chain using its certificate hash.
- simplify tests by unit testing each function (`check_path_is_an_empty_dir`, `check_dir_writable`, `check_disk_space`) instead of testing directly `check_prerequisites`. - renamed `check_prerequisites` to `check_prerequisites_for_archive` and added `check_prerequisites_for_uncompressed_data` for distinct verification flows. - renamed `check_disk_space` to `check_disk_space_for_archive` and added `check_disk_space_for_uncompressed_data` to separately validate disk space for uncompressed data.
…ride` options for `download` command
…base download command
…edback receiver Co-authored-by: DJO <Alenar@users.noreply.github.com>
Co-authored-by: DJO <Alenar@users.noreply.github.com>
…ent` Also add `digest` to `Full` variant for `DownloadEvent`. Co-authored-by: DJO <Alenar@users.noreply.github.com>
… clients to the downloader Co-authored-by: DJO <Alenar@users.noreply.github.com>
Co-authored-by: DJO <Alenar@users.noreply.github.com>
…ultiple downloads at once Co-authored-by: DJO <Alenar@users.noreply.github.com>
…DownloadProgressReporter` Co-authored-by: DJO <Alenar@users.noreply.github.com>
…porter` Co-authored-by: DJO <Alenar@users.noreply.github.com>
…bytes downloaded Co-authored-by: DJO <Alenar@users.noreply.github.com>
Also remove use of unnecessary `StdResult`. Co-authored-by: DJO <Alenar@users.noreply.github.com>
…oadProgressReporter` Co-authored-by: DJO <Alenar@users.noreply.github.com>
Co-authored-by: DJO <Alenar@users.noreply.github.com>
Co-authored-by: DJO <Alenar@users.noreply.github.com>
…n Mithril Client multi-platform test
- add a comment with an example of Windows canonicalize path for clarity in client `http` module - rename test in CLI `multi_download_progress_reporter` module
* mithril-client-cli from `0.11.2` to `0.11.3` * mithril-client from `0.11.4` to `0.11.5` * mithril-end-to-end from `0.4.70` to `0.4.71`
f5b2e88
to
a9c87ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR introduces a new
unstable
subcommand forcardano-db-v2
command in the client CLI.It allows users to restore an Incremental Cardano DB snapshots using the following options:
--start
: set the first immutable file number to download--end
: set the last immutable file number to download.--include-ancillary
: specify if the ancillary file must be downloaded--allow-override
: allow existing files in the download directory to be overridden.The command must be run with a specific snapshot
artifact_hash
or usinglatest
(fetch the latest produced artifact).A rework of the

IndicatifFeedbackReceiver
has been done to handle and display the Cardano database events sent by the client library:Additionally, the E2E test and the Mithril Client multi-platform test manual workflow have been updated to verify the command.
Examples:
Restore a full Cardano database:
Restore a Cardano database with ancillary files:
Restore from a starting point:
Restore using a range:
Restore until a end point:
Pre-submit checklist
Issue(s)
Closes #2246