Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add new Mithril certification section in website #2324

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Docs: add new Mithril certification section in website #2324

merged 8 commits into from
Feb 24, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 20, 2025 •
edited
Loading

Content

This PR includes the new Mithril certification section in the documentation website:

  • The Mithril certification page
  • The Cardano transactions certification page
  • The Cardano stake distribution certification page
  • The Cardano node database certification page.

Important

The rendered pages are available in this document: https://docs.google.com/document/d/1nRbdaSBAK-gOpSBflfvQVc3ORWH4QokEP7vagvJUCoY/

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #1700
Closes #2297
Closes #2298

@jpraynaud jpraynaud self-assigned this Feb 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Test Results

    3 files  ±0     52 suites  ±0   10m 39s ⏱️ -4s
1 657 tests ±0  1 657 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 963 runs  ±0  1 963 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 41cacc0. ± Comparison against base commit 01f83cd.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/documentation-how-data-type-are-signed branch from 086cada to de60f02 Compare February 21, 2025 10:47
sfauvel
sfauvel approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just some typo

dlachaume
dlachaume approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud force-pushed the jpraynaud/documentation-how-data-type-are-signed branch from de60f02 to 1bb55a4 Compare February 21, 2025 12:23
@jpraynaud jpraynaud requested a review from rezabaram February 24, 2025 08:50
olgahryniuk
olgahryniuk approved these changes Feb 24, 2025
View reviewed changes
@jpraynaud @olgahryniuk
fix: apply review comments
2f27bb1 
Co-authored-by: olgahryniuk <olgahryniuk@users.noreply.github.com>
Alenar
Alenar approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a great addition to the documentation 🔥

@jpraynaud jpraynaud merged commit 5f1dcab into main Feb 24, 2025
38 of 42 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/documentation-how-data-type-are-signed branch February 24, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@olgahryniuk olgahryniuk olgahryniuk approved these changes

@dlachaume dlachaume dlachaume approved these changes

@rezabaram rezabaram Awaiting requested review from rezabaram

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@jpraynaud @Alenar @sfauvel @olgahryniuk @dlachaume