Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: improve disk space calculation for Incremental DB Restoration #2345

Draft
wants to merge 2 commits into
base: sfa/2291/enhance_artifact_structure_for_incremental_cardano_db
Choose a base branch
from

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Mar 3, 2025

Content

This PR includes enhancements to the disk space computation for incremental Cardano DB snapshot restoration in the client CLI.
It leverages updated artifact metadata to compute the required disk space for both full and partial restorations, adding ancillary files sizes when necessary.
Additionally, for partial restorations, a 10% safety margin is applied to ensure that sufficient disk space is available before download, as the computation uses the average size of an immutable file.

⚠️ The pull request is still in draft because it will need to be merged after the branch https://github.com/input-output-hk/mithril/tree/sfa/2291/enhance_artifact_structure_for_incremental_cardano_db is merged.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2292

@dlachaume dlachaume self-assigned this Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

Test Results

    3 files  ±0     52 suites  ±0   10m 20s ⏱️ +8s
1 678 tests +3  1 678 ✅ +3  0 💤 ±0  0 ❌ ±0 
2 066 runs  +9  2 066 ✅ +9  0 💤 ±0  0 ❌ ±0 

Results for commit 69afdfb. ± Comparison against base commit 04d4a01.

@dlachaume dlachaume temporarily deployed to testing-preview March 3, 2025 16:38 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review March 3, 2025 17:33
@dlachaume dlachaume marked this pull request as draft March 3, 2025 17:33
@dlachaume dlachaume requested review from jpraynaud and sfauvel March 3, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant