-
Notifications
You must be signed in to change notification settings - Fork 45
Feat: move database vacuum to aggregator startup to avoid API interruptions during epoch transitions #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dlachaume
merged 7 commits into
main
from
dlachaume/2364/avoid-database-vacuum-blocking-aggregator-api
Mar 18, 2025
Merged
Feat: move database vacuum to aggregator startup to avoid API interruptions during epoch transitions #2375
dlachaume
merged 7 commits into
main
from
dlachaume/2364/avoid-database-vacuum-blocking-aggregator-api
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
087c436
to
92e845a
Compare
…ggregator startup with minimum interval
92e845a
to
b5e416f
Compare
Alenar
approved these changes
Mar 17, 2025
sfauvel
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…code to create log message
jpraynaud
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* mithril-aggregator from `0.7.16` to `0.7.17`
8decd2f
to
8730458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix for the API unavailability during epoch transitions by moving database vacuum operation from the upkeep service to aggregator startup.
The main changes are:
VacuumTracker
utility that tracks when the last vacuum operation was performedPre-submit checklist
Issue(s)
Closes #2364