Skip to content

Organize STM - Blst multi_sig module #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

Organize STM - Blst multi_sig module #2405

merged 3 commits into from
Apr 7, 2025

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Apr 2, 2025 •
edited
Loading

Content

This PR includes a module for covering the multi-signature operations of blst library used by stm.rs.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2369

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 2, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

Test Results

    3 files  ±0     57 suites  ±0   11m 30s ⏱️ -8s
1 812 tests ±0  1 812 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 218 runs  ±0  2 218 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1477269. ± Comparison against base commit 2b16700.

This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both. 
mithril-stm ‑ multi_sig::tests::batch_verify
mithril-stm ‑ multi_sig::tests::serialize_deserialize_sk
mithril-stm ‑ multi_sig::tests::serialize_deserialize_vk
mithril-stm ‑ multi_sig::tests::test_aggregate_sig
mithril-stm ‑ multi_sig::tests::test_eval_sanity_check
mithril-stm ‑ multi_sig::tests::test_infinity_sig
mithril-stm ‑ multi_sig::tests::test_infinity_vk
mithril-stm ‑ multi_sig::tests::test_invalid_sig
mithril-stm ‑ multi_sig::tests::test_keyreg_with_infinity_vk
mithril-stm ‑ multi_sig::tests::test_sig

mithril-stm ‑ bls_multi_signature::tests::batch_verify
mithril-stm ‑ bls_multi_signature::tests::serialize_deserialize_sk
mithril-stm ‑ bls_multi_signature::tests::serialize_deserialize_vk
mithril-stm ‑ bls_multi_signature::tests::test_aggregate_sig
mithril-stm ‑ bls_multi_signature::tests::test_eval_sanity_check
mithril-stm ‑ bls_multi_signature::tests::test_infinity_sig
mithril-stm ‑ bls_multi_signature::tests::test_infinity_vk
mithril-stm ‑ bls_multi_signature::tests::test_invalid_sig
mithril-stm ‑ bls_multi_signature::tests::test_keyreg_with_infinity_vk
mithril-stm ‑ bls_multi_signature::tests::test_sig

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt force-pushed the curiecrypt/module-bls-base branch from 7919df7 to 72509aa Compare April 2, 2025 15:46
@curiecrypt curiecrypt temporarily deployed to testing-preview April 2, 2025 16:26 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 3, 2025
View reviewed changes
@curiecrypt curiecrypt temporarily deployed to testing-preview April 4, 2025 12:39 — with GitHub Actions Inactive
@curiecrypt curiecrypt requested a review from jpraynaud April 4, 2025 12:41
jpraynaud
jpraynaud approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments below

@curiecrypt curiecrypt temporarily deployed to testing-preview April 4, 2025 22:20 — with GitHub Actions Inactive
@curiecrypt curiecrypt force-pushed the curiecrypt/module-bls-base branch from b4b5217 to 4553f17 Compare April 7, 2025 15:25
@curiecrypt
working bls multi sig module
b5c9834 
organize multi_sig mod

module doc

update benches import

review suggestions

review suggestions
@curiecrypt
change log and crates version
1477269 
crates version
@curiecrypt curiecrypt force-pushed the curiecrypt/module-bls-base branch from 4553f17 to 1477269 Compare April 7, 2025 15:28
@curiecrypt curiecrypt marked this pull request as ready for review April 7, 2025 15:33
@curiecrypt curiecrypt temporarily deployed to testing-preview April 7, 2025 15:37 — with GitHub Actions Inactive
@curiecrypt curiecrypt merged commit 02301d9 into main Apr 7, 2025
38 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/module-bls-base branch April 7, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curiecrypt @jpraynaud