Skip to content

Feat(infra): support follower aggregator in infra #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 14, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 2, 2025

Content

This PR includes an update of the terraform infrastructure for Mithril networks:

  • An optional leader aggregator
  • An optional bootstrap peer for the P2P network
  • Add Passthrough or P2P option for signer registration in the signer relay
  • Add Passthrough or P2P option for signature registration in the signer relay
  • Simplified the docker compose files with merging for signer and aggregator
  • Adapt the aggregator infrastructure for follower aggregator
  • Adapt the signer infrastructure for follower aggregator
  • Adapt the CI workflows
  • Add a new dev-follower-preview network

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Closes #2391

@jpraynaud jpraynaud self-assigned this Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 38s ⏱️ -7s
1 831 tests ±0  1 831 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 245 runs  ±0  2 245 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5b26a66. ± Comparison against base commit 985975d.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch 2 times, most recently from 3bd63be to 37f788a Compare April 3, 2025 10:26
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 10:26 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 10:41 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 37f788a to 68048dc Compare April 3, 2025 10:50
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 10:51 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 68048dc to 0e60143 Compare April 3, 2025 10:58
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 10:58 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 0e60143 to 15c9e69 Compare April 3, 2025 11:02
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 11:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-preview-follower April 3, 2025 11:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview April 3, 2025 11:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 15c9e69 to d0d3009 Compare April 3, 2025 12:32
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 3, 2025 12:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 630964f to 210945e Compare April 10, 2025 15:05
@jpraynaud jpraynaud temporarily deployed to testing-preview April 10, 2025 15:22 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review April 10, 2025 16:37
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 210945e to 67fbd82 Compare April 14, 2025 09:24
@jpraynaud jpraynaud force-pushed the jpraynaud/2391-follower-aggregators-infra branch from 67fbd82 to 5b26a66 Compare April 14, 2025 09:39
@jpraynaud jpraynaud temporarily deployed to testing-preview April 14, 2025 10:51 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 27f8d53 into main Apr 14, 2025
41 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2391-follower-aggregators-infra branch April 14, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt infrastructure for multiple aggregators with leader/follower signer registration
3 participants