Skip to content

explorer: support latest ancillary & cardano database v2 developments #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

explorer: support latest ancillary & cardano database v2 developments #2418

merged 3 commits into from
Apr 11, 2025

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Apr 10, 2025 •
edited
Loading

Content

This PR:

  • cardano database v1:
    • update Archive size to encompass both immutable files and ancillary archive size
    • add a tooltip next to Archive size that details the two sizes
      image
  • cardano database v2:
    • remove Compression algorithm as it's now a property that can vary per locations
    • fix download popup: it was not updated to the changes to the structure where location are now part of each subtype
  • upgrade explorer to Next 15.3 and React 19.1

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2362, #2291

@Alenar Alenar self-assigned this Apr 10, 2025
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • mithril-explorer/package.json: Language not supported

@Alenar Alenar force-pushed the djo/2362/update-explorer branch from b89ef6a to bfb9524 Compare April 10, 2025 16:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Test Results

    3 files  ±0     57 suites  ±0   11m 41s ⏱️ +12s
1 830 tests ±0  1 830 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 244 runs  ±0  2 244 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f8a032. ± Comparison against base commit c461e08.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview April 10, 2025 16:24 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlachaume
dlachaume approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Alenar added 2 commits April 11, 2025 12:01
@Alenar
feat(explorer): adapt to latest cardano db v1/v2 changes
42f3905 
* cdb v1: update `Archive size` to encompass both immutables + ancillary
  archive size + add a tooltip that details the two sizes
* cdb v2:
  * remove Compression algorithm as it's now a property that can vary
    per locations
  * fix download popup: it was not updated to the changes to the
    structure where location are now part of each subtype
@Alenar
chore: upgrade crate versions
0f8a032 
* [js] mithril-explorer from `0.7.33` to `0.7.34`
@Alenar Alenar force-pushed the djo/2362/update-explorer branch from bfb9524 to 0f8a032 Compare April 11, 2025 10:01
@Alenar Alenar temporarily deployed to testing-preview April 11, 2025 10:10 — with GitHub Actions Inactive
@Alenar Alenar merged commit 89e74e3 into main Apr 11, 2025
38 checks passed
@Alenar Alenar deleted the djo/2362/update-explorer branch April 11, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

@turmelclem turmelclem Awaiting requested review from turmelclem

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @dlachaume