Skip to content

Fix aggregator path in stress test #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Apr 15, 2025

Content

Aggregator configuration was not updated when implementing #2380.

This PR

  • fix paths use be the aggregator in stress test:
    • a Ledger file is added to the cardano DB
    • the aggregator is build with the root path and not the immutable path
  • handle status code 550 as the registration round not open (see Error messages as warning in signer #2381)
  • upload artifacts in CI to help debugging

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Closes #2408

@sfauvel sfauvel marked this pull request as ready for review April 15, 2025 09:24
Copy link

github-actions bot commented Apr 15, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 49s ⏱️ +16s
1 856 tests ±0  1 856 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 318 runs  ±0  2 318 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8dd3b7e. ± Comparison against base commit 0b411ea.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview April 15, 2025 09:27 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel temporarily deployed to testing-preview April 16, 2025 08:10 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/2408/fix_aggregator_stress_test branch from d94a9f5 to 7973804 Compare April 16, 2025 09:15
@sfauvel sfauvel temporarily deployed to testing-preview April 16, 2025 09:23 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/2408/fix_aggregator_stress_test branch from 7973804 to 9327fbf Compare April 16, 2025 09:46
@sfauvel sfauvel temporarily deployed to testing-preview April 16, 2025 09:55 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/2408/fix_aggregator_stress_test branch from 9327fbf to 8dd3b7e Compare April 16, 2025 10:16
@sfauvel sfauvel temporarily deployed to testing-preview April 16, 2025 10:32 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 1abf70c into main Apr 16, 2025
42 of 43 checks passed
@sfauvel sfauvel deleted the ensemble/2408/fix_aggregator_stress_test branch April 16, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregator stress test is failing
5 participants