Skip to content

Fix: better error handling for era reader adapter parameters in infra #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 5, 2025
Merged

Fix: better error handling for era reader adapter parameters in infra #2452

merged 7 commits into from
May 5, 2025
+22 −7

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 30, 2025 •
edited
Loading

Content

This PR includes a better error handling for the computation of era reader adapter parameters for the signer and the aggregator in infra:

  • the computations rely on remote file downloads which can fail
  • if the command that computes the parameter fails, the terraform deployment will fail

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2451

@jpraynaud
fix(infra): better error handling of era reader params
ef55db4
@jpraynaud
chore: upgrade infra version
f62b34f 
* mithril-infra/assets/infra.version from `0.4.4` to `0.4.5`
@jpraynaud jpraynaud self-assigned this Apr 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

Test Results

    3 files  ±0     57 suites  ±0   11m 37s ⏱️ +11s
1 880 tests ±0  1 880 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 342 runs  ±0  2 342 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 29de23d. ± Comparison against base commit 47178ad.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview April 30, 2025 10:09 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 13:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 13:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/better-handling-era-reader-adapter-params-infra branch from 51c7714 to efac36b Compare April 30, 2025 14:03
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:03 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/better-handling-era-reader-adapter-params-infra branch from efac36b to 9df844d Compare April 30, 2025 14:05
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:05 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/better-handling-era-reader-adapter-params-infra branch from 9df844d to 7ea6c76 Compare April 30, 2025 14:08
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:15 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/better-handling-era-reader-adapter-params-infra branch from f2333f2 to d97a945 Compare April 30, 2025 14:24
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:29 — with GitHub Actions Inactive
@jpraynaud
fix(infra): fixed era reader params error not being caught
29de23d 
Which prevented failure of the terraform deployment when the computation inside  block fails.
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview April 30, 2025 14:39 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview April 30, 2025 14:52 — with GitHub Actions Inactive
turmelclem
turmelclem approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud temporarily deployed to dev-follower-preview May 5, 2025 10:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to dev-follower-preview May 5, 2025 10:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 62c5d73 into main May 5, 2025
50 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/better-handling-era-reader-adapter-params-infra branch May 5, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

@turmelclem turmelclem turmelclem approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @dlachaume @turmelclem