Skip to content

Feat: implement signature publisher decorators in signer #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 13, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented May 6, 2025

Content

This PR includes the implementation of signature publisher decorators in the signer node, introducing a retrier publisher and a delayer publisher to facilitate future integration with a DMQ-based diffusion mechanism.

Additionally, signature publisher parameters have been made configurable to support execution in both end-to-end test and production environments. The default values are:
SIGNATURE_PUBLISHER_RETRY_ATTEMPTS: 3 attempts
SIGNATURE_PUBLISHER_RETRY_DELAY_MS: 2,000 milliseconds
SIGNATURE_PUBLISHER_DELAY_MS: 10,000 milliseconds

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2461

@dlachaume dlachaume self-assigned this May 6, 2025
@dlachaume dlachaume changed the title Dlachaume/2461/signer signature publisher decorators Feat: implement signer signature publisher decorators May 6, 2025
@dlachaume dlachaume changed the title Feat: implement signer signature publisher decorators Feat: implement signature publisher decorators in signer May 6, 2025
Copy link

github-actions bot commented May 6, 2025

Test Results

    3 files  ±0     57 suites  ±0   11m 39s ⏱️ -7s
1 905 tests +9  1 905 ✅ +9  0 💤 ±0  0 ❌ ±0 
2 379 runs  +9  2 379 ✅ +9  0 💤 ±0  0 ❌ ±0 

Results for commit 6bb77b3. ± Comparison against base commit 346b447.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from 1d4e2d3 to d62bf6b Compare May 7, 2025 08:51
@dlachaume dlachaume temporarily deployed to testing-preview May 7, 2025 14:40 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch 2 times, most recently from 91119b5 to 324823e Compare May 7, 2025 14:45
@dlachaume dlachaume marked this pull request as ready for review May 7, 2025 14:54
@dlachaume dlachaume requested review from jpraynaud and turmelclem May 7, 2025 14:54
@dlachaume dlachaume temporarily deployed to testing-preview May 7, 2025 14:54 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from 324823e to 2b40cb3 Compare May 7, 2025 16:45
@dlachaume dlachaume temporarily deployed to testing-preview May 7, 2025 16:54 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from 2b40cb3 to 13740de Compare May 9, 2025 08:45
@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from 13740de to a6f7406 Compare May 9, 2025 08:47
@dlachaume dlachaume temporarily deployed to testing-preview May 9, 2025 08:56 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from a6f7406 to 0bbeae3 Compare May 9, 2025 09:00
@dlachaume dlachaume temporarily deployed to testing-preview May 9, 2025 09:09 — with GitHub Actions Inactive
@dlachaume dlachaume requested a review from Alenar May 9, 2025 13:01
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/2461/signer-signature-publisher-decorators branch from 0bbeae3 to da81fd6 Compare May 12, 2025 15:16
* mithril-signer from `0.2.245` to `0.2.246`
* mithril-end-to-end from `0.4.84` to `0.4.85`
@dlachaume dlachaume temporarily deployed to testing-preview May 12, 2025 15:30 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview May 12, 2025 15:39 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 9df5a56 into main May 13, 2025
39 checks passed
@dlachaume dlachaume deleted the dlachaume/2461/signer-signature-publisher-decorators branch May 13, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement delayer and retrier decorators of the signature publisher in signer
4 participants