-
Notifications
You must be signed in to change notification settings - Fork 45
Feat: implement signature publisher decorators in signer #2468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dlachaume
merged 9 commits into
main
from
dlachaume/2461/signer-signature-publisher-decorators
May 13, 2025
Merged
Feat: implement signature publisher decorators in signer #2468
dlachaume
merged 9 commits into
main
from
dlachaume/2461/signer-signature-publisher-decorators
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d4e2d3
to
d62bf6b
Compare
91119b5
to
324823e
Compare
jpraynaud
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mithril-signer/src/services/signature_publisher/signature_publisher_delayer.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_delayer.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_delayer.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_noop.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_retrier.rs
Show resolved
Hide resolved
324823e
to
2b40cb3
Compare
2b40cb3
to
13740de
Compare
13740de
to
a6f7406
Compare
a6f7406
to
0bbeae3
Compare
turmelclem
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alenar
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mithril-signer/src/services/signature_publisher/signature_publisher_delayer.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_delayer.rs
Outdated
Show resolved
Hide resolved
mithril-signer/src/services/signature_publisher/signature_publisher_retrier.rs
Outdated
Show resolved
Hide resolved
…tion for DMQ/HTTP coexistence
…isherRetrier` and `SignaturePublisherDelayer`
…h the new parameters
0bbeae3
to
da81fd6
Compare
* mithril-signer from `0.2.245` to `0.2.246` * mithril-end-to-end from `0.4.84` to `0.4.85`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the implementation of signature publisher decorators in the signer node, introducing a
retrier
publisher and adelayer
publisher to facilitate future integration with a DMQ-based diffusion mechanism.Additionally, signature publisher parameters have been made configurable to support execution in both end-to-end test and production environments. The default values are:
SIGNATURE_PUBLISHER_RETRY_ATTEMPTS
: 3 attemptsSIGNATURE_PUBLISHER_RETRY_DELAY_MS
: 2,000 millisecondsSIGNATURE_PUBLISHER_DELAY_MS
: 10,000 millisecondsPre-submit checklist
Issue(s)
Closes #2461