Split mithril-common phase 2: extract Mithril test http server

[Alenar]

Content

This PR extract the TestHttpServer tooling from mithril-common into a dedicated internal/tests/mithril-test-http-server crate.

Additional changes

• Removal fs, apispec, test_http_server from mithril-common
• Bump of mithril-common minor version to 0.6.0
• The http server used in mithril-client integration tests have been switched from TestHttpServer to axum_test::TestServer
  • This mean that the routes code had to be converted from warp to axum
  • This have the udge benefits of avoiding a publication of the new mithril-test-http-server to crates.io
• Reactivation of testing of most internal crates in the CI when targeting windows
• Build and test missing, almost all, internal crates in Hydra CI
• Refactor MetricServer init in a two part process MetricServer::build(ip, port, {args..}).bind().serve() in order to be able to get the effective bound port even if 0 is provided to let the system pick a available port.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • No new TODOs introduced

Comments

Issue(s)

Relates to #2392

[github-actions]

Test Results

    3 files  ±  0    102 suites  +8   16m 18s ⏱️ + 2m 48s
2 036 tests ±  0  2 036 ✅ ±  0  0 💤 ±0  0 ❌ ±0 
4 209 runs  +507  4 209 ✅ +507  0 💤 ±0  0 ❌ ±0 

Results for commit 72dd3e4. ± Comparison against base commit 93d00d6.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.

mithril-common ‑ test_utils::test_http_server::tests::test_server_simple_http
mithril-common ‑ test_utils::test_http_server::tests::test_server_simple_json
mithril-common ‑ test_utils::test_http_server::tests::test_server_specific_route
mithril-common ‑ test_utils::test_http_server::tests::test_server_unbind_route_yield_404

mithril-test-http-server ‑ test_http_server::tests::test_server_simple_http
mithril-test-http-server ‑ test_http_server::tests::test_server_simple_json
mithril-test-http-server ‑ test_http_server::tests::test_server_specific_route
mithril-test-http-server ‑ test_http_server::tests::test_server_unbind_route_yield_404

♻️ This comment has been updated with latest results.

[turmelclem]

LGTM

[Copilot]

Pull Request Overview

This PR extracts the TestHttpServer tooling from mithril‐common into a dedicated internal/tests/mithril-test-http-server crate and updates related tests and components to use the new axum‐based API and builder patterns. Key changes include:

• Renaming and updating MetricsServer API calls from .start() to .serve() via a builder.
• Migrating test server return types in FakeAggregator’s spawn methods from TestHttpServer to Self.
• Updating client tests to use the new server URL accessor (server_root_url) and corresponding dependency updates.

Reviewed Changes

Copilot reviewed 40 out of 41 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
mithril-signer/src/main.rs	Updated MetricsServer instantiation and method call to match the new builder API.
mithril-relay/src/relay/signer.rs	Adjusted import paths to reference the new mithril-test-http-server crate.
mithril-client/tests/*	Updated FakeAggregator spawn methods and client URL accessor to use the new server API.
mithril-common/Cargo.toml, mithril-aggregator/Cargo.toml	Modified dependency definitions to include and reference the new test-http-server crate.
internal/tests/mithril-test-http-server/*	New crate providing dedicated test HTTP server functionality.

Comments suppressed due to low confidence (3)

mithril-signer/src/main.rs:284

• The MetricsServer API call has been updated from .start() to .serve() via a builder. Ensure that the new builder pattern and graceful shutdown behavior are correctly integrated here.

            .serve(stop_rx_clone)

mithril-client/tests/extensions/fake_aggregator/certificate.rs:8

• The spawn_with_certificate method's return type has been changed from TestHttpServer to Self. Verify that all consumers of this method are updated to handle the new return type accordingly.

    pub fn spawn_with_certificate(certificate_hash_list: &[String]) -> Self {

mithril-client/tests/snapshot_list_get_show_download_verify.rs:38

• The client initialization now uses fake_aggregator.server_root_url() instead of test_http_server.url(), reflecting the updated test server API. Confirm that this change is consistent across all affected tests.

        ClientBuilder::aggregator(&fake_aggregator.server_root_url(), genesis_verification_key)

[jpraynaud]

LGTM 👍