-
Notifications
You must be signed in to change notification settings - Fork 45
Remove cardano-db-v2 and make cardano-db --backend v2 stable #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58e6305
to
483c30b
Compare
Test Results 3 files ±0 102 suites ±0 16m 18s ⏱️ -24s Results for commit 272ac01. ± Comparison against base commit f28a611. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
6d5ca51
to
e195305
Compare
6ee707f
to
c5139cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated cardano-db-v2 commands and consolidates backend handling so that the stable cardano-db command accepts a --backend option (v1 or v2). Key changes include:
- Updating CLI command construction to always include an explicit --backend option.
- Removing the cardano-db-v2 modules, tests, and documentation references.
- Revising user-facing messages and CI workflows to reflect the new command usage.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
mithril-test-lab/mithril-end-to-end/src/mithril/client.rs | Adjusts argument composition to include explicit backend flags. |
mithril-client-cli/src/main.rs | Removes deprecated cardano-db-v2 commands and associated tests. |
mithril-client-cli/src/commands/cardano_db/{show, list, verify, download, mod.rs} | Updates command implementations to use the unified --backend option. |
docs/website/root/manual/**/* | Revises documentation to eliminate references to cardano-db-v2. |
.github/workflows/test-client.yml | Updates CI commands to use the new --backend flags and removes --unstable. |
Comments suppressed due to low confidence (5)
mithril-test-lab/mithril-end-to-end/src/mithril/client.rs:225
- Ensure that replacing the '--unstable' flag with the explicit '--backend' option is compatible with all client use cases and that any clients relying on the old flag semantics are updated accordingly.
cmd.cli_arg(),
mithril-client-cli/src/main.rs:205
- Confirm that all documentation and error messages referencing the old cardano-db-v2 command are removed or updated to prevent user confusion.
CardanoStakeDistribution(CardanoStakeDistributionCommands),
mithril-client-cli/src/commands/cardano_db/verify.rs:170
- Ensure that the simplified verification message is consistent with similar messages in other modules, so users receive a unified experience.
println!("Cardano database snapshot '{snapshot_hash}' archives have been successfully verified. Immutable files have been successfully checked with Mithril.");
docs/website/root/manual/getting-started/bootstrap-cardano-node.md:478
- [nitpick] Verify that this updated message matches the output of the CLI across all similar commands in order to ensure consistency.
Cardano db 'a1b5e6f43521fd9c5f55e3d6bf27dc4a62f43980681cb67e28cc40582a0d1974' has been unpacked and successfully checked with Mithril.
.github/workflows/test-client.yml:256
- Double-check that all CI workflow steps consistently reference the updated '--backend' flag and have no residual usage of the '--unstable' flag.
run: ./mithril-client --origin-tag CI cardano-db snapshot show --backend v2 $CARDANO_DATABASE_V2_SNAPSHOT_HASH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
c5139cb
to
d72a551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d72a551
to
96aa33b
Compare
* mithril-client-cli from `0.12.13` to `0.12.14` * mithril-end-to-end from `0.4.91` to `0.4.92`
5cc247e
to
b9ae69e
Compare
b9ae69e
to
272ac01
Compare
Content
This PR includes...
cardano-db --backend v2
stablecardano-db-v2
and usecardano-db --backend v2
instead in in CI and e2e testscardano-db --backend v1
instead of default backend version in CI and e2e testscardano-db
download
andverify
commandsPre-submit checklist
Relate to #2577