-
Notifications
You must be signed in to change notification settings - Fork 45
filip(feat): docs site redesign #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The site is pretty now, many thanks 🔥 🚀
I've made few comments but overall it's seems good !
I've seen two additional issues:
- The close button on the announcement bar is dark on a dark background:
- On both chrome and firefox the main page there's a horizontal scoll bar that appears, allowing to scroll out of bound, also in firefox if you keep scrooling using a scroll wheel either vertically or horizontally you can go out of bound easilly
Chrome horizontal scroll bar
Screencast.from.2025-06-20.10-23-26.webm
Firefox horizontal scroll bar
Note
only appear on large viewport
Note
You can see the vertical scroll bar changing size by a huge margin (going from large to small) at the same time that the horizontal scroll bar appear
Screencast.from.2025-06-20.10-28-42.webm
Firefox scroll wheel out of bound
Screencast.from.2025-06-20.10-26-01.webm
Not a bug, but from what I understand the base of the customized theme components in src/theme
is the docusaurus-theme-classic code. this leaves me with a few open questions:
- Will it make us harder to upgrade to docusaurus latest version in the future ? We may have to backport the modifications on the customized theme components to upgrade (note: docusaurus 4 is coming and will rework its CSS).
- I see that the Copyright comment on all copied components have been removed, is this ok ? Won't this cause legal issues ?
i.e.PrimaryMenu
on the PR branch vsPrimaryMenu
on docusaurus source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @fstoqnov-iohk for the good work! LGTM 🚀
I align with @Alenar comments, in particular those concerning the licensing/copyrights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a new error introduced in the latest changes.
@fstoqnov-iohk We had a little hiccup with prettier this morning (cf #2601), can you rebase your branch on |
58bc58a
to
e883e4e
Compare
Implemented new agreed on docs site designs