Skip to content

filip(feat): docs site redesign #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 24, 2025
Merged

Conversation

fstoqnov-iohk
Copy link
Collaborator

Implemented new agreed on docs site designs

  • New homepage
  • Updated look and feel of nav and footer
  • Tweaks to the docs/blog pages
  • Minor adjustments to some of the markdwon components

Copy link

github-actions bot commented Jun 19, 2025

Test Results

    3 files  ±0    102 suites  ±0   16m 47s ⏱️ -30s
2 035 tests ±0  2 035 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 206 runs  ±0  4 206 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1a51d2e. ± Comparison against base commit ea995a0.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site is pretty now, many thanks 🔥 🚀

I've made few comments but overall it's seems good !

I've seen two additional issues:

  1. The close button on the announcement bar is dark on a dark background:
    image
  2. On both chrome and firefox the main page there's a horizontal scoll bar that appears, allowing to scroll out of bound, also in firefox if you keep scrooling using a scroll wheel either vertically or horizontally you can go out of bound easilly

Chrome horizontal scroll bar

Screencast.from.2025-06-20.10-23-26.webm

Firefox horizontal scroll bar

Note

only appear on large viewport

Note

You can see the vertical scroll bar changing size by a huge margin (going from large to small) at the same time that the horizontal scroll bar appear

Screencast.from.2025-06-20.10-28-42.webm

Firefox scroll wheel out of bound

Screencast.from.2025-06-20.10-26-01.webm

Not a bug, but from what I understand the base of the customized theme components in src/theme is the docusaurus-theme-classic code. this leaves me with a few open questions:

  1. Will it make us harder to upgrade to docusaurus latest version in the future ? We may have to backport the modifications on the customized theme components to upgrade (note: docusaurus 4 is coming and will rework its CSS).
  2. I see that the Copyright comment on all copied components have been removed, is this ok ? Won't this cause legal issues ?
    i.e. PrimaryMenu on the PR branch vs PrimaryMenu on docusaurus source

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @fstoqnov-iohk for the good work! LGTM 🚀

I align with @Alenar comments, in particular those concerning the licensing/copyrights.

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a new error introduced in the latest changes.

@Alenar
Copy link
Collaborator

Alenar commented Jun 23, 2025

@fstoqnov-iohk We had a little hiccup with prettier this morning (cf #2601), can you rebase your branch on main and ensure that the CI / check step is green ?

@fstoqnov-iohk fstoqnov-iohk force-pushed the filip/feat/docs-landing-page-new branch from 58bc58a to e883e4e Compare June 23, 2025 12:28
@jpraynaud jpraynaud merged commit ea505e4 into main Jun 24, 2025
66 of 67 checks passed
@jpraynaud jpraynaud deleted the filip/feat/docs-landing-page-new branch June 24, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants