feat: simple aggregator discovery #2779
Draft
+1,552
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Copilot finished reviewing on behalf of
jpraynaud
November 14, 2025 16:12
There was a problem hiding this comment.
Pull Request Overview
This PR implements a simple aggregator discovery mechanism to enable the Mithril client to automatically discover and connect to available aggregators in a network.
Key changes:
- Introduces a new
mithril-aggregator-discoverycrate with discoverer implementations - Refactors the
ClientBuilderAPI to support aggregator discovery modes (automatic vs. explicit URL) - Adds capability-based filtering and randomization of aggregator selection
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
internal/mithril-aggregator-discovery/Cargo.toml |
Defines the new aggregator discovery crate with dependencies |
internal/mithril-aggregator-discovery/src/lib.rs |
Exports the public API for aggregator discovery |
internal/mithril-aggregator-discovery/src/interface.rs |
Defines the AggregatorDiscoverer trait |
internal/mithril-aggregator-discovery/src/model.rs |
Implements MithrilNetwork and AggregatorEndpoint models |
internal/mithril-aggregator-discovery/src/http_config_discoverer.rs |
HTTP-based discoverer that fetches aggregator lists from remote configuration |
internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs |
Filters aggregators by required capabilities |
internal/mithril-aggregator-discovery/src/rand_discoverer.rs |
Shuffles aggregator order using randomization |
internal/mithril-aggregator-discovery/src/test/ |
Test utilities and doubles for testing |
mithril-client/src/client.rs |
Refactors client builder to support aggregator discovery |
mithril-client/Cargo.toml |
Adds dependency on the new discovery crate |
Makefile, Cargo.toml, .github/workflows/ci.yml |
Build configuration updates |
README.md |
Documentation for the new crate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/mithril-aggregator-discovery/src/test/double/discoverer.rs
Outdated
Show resolved
Hide resolved
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
945d3c2 to
c74fb50
Compare
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
c74fb50 to
434891f
Compare
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
434891f to
c9f8423
Compare
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
c9f8423 to
8101ed2
Compare
Copilot finished reviewing on behalf of
jpraynaud
November 24, 2025 18:16
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 25 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs
Outdated
Show resolved
Hide resolved
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
8101ed2 to
4a5ec0d
Compare
Implementation for 'AggregatorDiscoverer' trait.
…ementation of 'Iterator' trait
…ities' type Which allows to combine signed entity types and aggregate signature type in a flexible way.
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
4a5ec0d to
bbb18cb
Compare
Copilot finished reviewing on behalf of
jpraynaud
November 28, 2025 16:57
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 33 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/mithril-aggregator-discovery/src/http_config_discoverer.rs
Outdated
Show resolved
Hide resolved
internal/mithril-aggregator-discovery/src/http_config_discoverer.rs
Outdated
Show resolved
Hide resolved
jpraynaud
force-pushed
the
jpraynaud/2726-simple-aggregator-discovery
branch
from
bbb18cb to
9a0ab5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR introduces a simple Aggregator Discovery functionality to the Mithril client library and CLI, allowing clients to automatically discover and connect to suitable aggregators based on their capabilities rather than requiring a hardcoded aggregator endpoint:
New
mithril-aggregator-discoverycrateA standalone crate providing aggregator discovery functionality:
AggregatorDiscoverertrait for extensible discovery mechanismsHttpConfigAggregatorDiscovererfor fetching aggregator lists from HTTP endpointsShuffleAggregatorDiscovererdecorator for randomizing aggregator selectionCapableAggregatorDiscovererdecorator for filtering aggregators by required capabilitiesMithrilNetworktype tomithril-commonfor shared usageRequiredAggregatorCapabilitiestype for cleaner capability filteringClient integration
aggregator_discoverer()method in client builder as the recommended way to configure aggregatorsaggregator()constructor in favor ofnewconstructor####CLI enhancements
tools aggregator-discoverycommand (unstable) to list available aggregators--jsonflagPre-submit checklist
Issue(s)
Closes #2726