Update index.js #825
Open
Update index.js #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update extension/index.js to account for the fact that Blockfrost page limit is set to a maximum of 100. Providing a larger integer value to paginate.limit results in an error to the user.
|
The rationale here being that other wallet providers may allow for a greater page limit than 100 and dApp developers should not need to analyze which wallet they are connected to in order to determine that wallet's page limit. So, if a value > Blockfrost limit is supplied, cap it to Blockfrost limit. |
rhyslbw
force-pushed
the
main
branch
5 times, most recently
from
9dd4cd2
to
4b947a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update extension/index.js to account for the fact that Blockfrost page limit is set to a maximum of 100. Providing a larger integer value to paginate.limit results in an error to the user.