This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
PLT-9274 - Atlantis EC2 instance and subsequent infrastructure to support it. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
atlantis apply -d infra/us-east-1/mgmt/atlantis/ecr |
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (3)
- infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl (1 hunks)
- infra/us-east-1/mgmt/atlantis/ecr/terragrunt.hcl (1 hunks)
- infra/us-east-1/mgmt/atlantis/security-group/terragrunt.hcl (1 hunks)
Additional comments: 8
infra/us-east-1/mgmt/atlantis/security-group/terragrunt.hcl (3)
- 1-13: The
localsblock is well-structured, providing a clear hierarchy and reuse of variables. It's good to see the use offind_in_parent_foldersto keep the configuration DRY.- 15-17: The
terraformblock specifies the source of the security group module. Ensure that the referenced versionv5.1.0of theterraform-aws-security-groupmodule is compatible with the rest of the infrastructure and Terraform version in use.- 24-26: The
dependencyblock for the VPC is correctly set up to reference the VPC configuration. However, ensure that the VPC configuration is applied and has the necessary outputs, especiallyvpc_id, which is used in the inputs block.infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl (2)
- 1-12: The
localsblock is well-structured and follows the same pattern as the security-group configuration, which is good for consistency across modules.- 14-16: The
terraformblock specifies the source of the EC2 instance module. Ensure that the referenced versionv5.6.0of theterraform-aws-ec2-instancemodule is compatible with the Terraform version in use.infra/us-east-1/mgmt/atlantis/ecr/terragrunt.hcl (3)
- 1-39: The
localsblock is consistent with the other modules, and the lifecycle policy is well-defined with clear rules for managing the ECR repository images.- 41-43: The
terraformblock specifies the source of the ECR module. Ensure that the referenced versionv1.6.0of theterraform-aws-ecrmodule is compatible with the Terraform version in use.- 45-48: The
inputsblock correctly sets up the ECR repository with a lifecycle policy. Ensure that therepository_nameis unique and follows any naming conventions that may be in place.
Comment on lines
+28
to
+33
| inputs = { | ||
| vpc_id = dependency.vpc.outputs.vpc_id | ||
|
|
||
| computed_ingress_cidr_blocks = ["0.0.0.0/0"] | ||
| ingress_cidr_blocks = ["0.0.0.0/0"] | ||
| } |
There was a problem hiding this comment.
The inputs block defines ingress rules with CIDR blocks set to 0.0.0.0/0, which allows unrestricted access. This is a potential security risk. Recommend restricting the ingress to only necessary IP ranges.
- computed_ingress_cidr_blocks = ["0.0.0.0/0"]
- ingress_cidr_blocks = ["0.0.0.0/0"]
+ computed_ingress_cidr_blocks = ["<restricted-ip-range>"]
+ ingress_cidr_blocks = ["<restricted-ip-range>"]Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| inputs = { | |
| vpc_id = dependency.vpc.outputs.vpc_id | |
| computed_ingress_cidr_blocks = ["0.0.0.0/0"] | |
| ingress_cidr_blocks = ["0.0.0.0/0"] | |
| } | |
| inputs = { | |
| vpc_id = dependency.vpc.outputs.vpc_id | |
| computed_ingress_cidr_blocks = ["<restricted-ip-range>"] | |
| ingress_cidr_blocks = ["<restricted-ip-range>"] | |
| } |
Comment on lines
+22
to
+24
| dependency "security_group" { | ||
| config_path = "../security-group" | ||
| } |
There was a problem hiding this comment.
The verification process has consistently shown that there is no output for security_group_id in the terragrunt.hcl file within the security group configuration directory. This suggests that the review comment is correct in stating that the security group configuration needs to have the necessary outputs, especially security_group_id, which is not currently present.
Analysis chain
The dependency block for the security group is correctly set up. Ensure that the security group configuration is applied and has the necessary outputs, especially security_group_id, which is used in the inputs block.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the security group configuration has been applied and outputs the necessary security_group_id.
rg --type hcl 'output "security_group_id"' infra/us-east-1/mgmt/atlantis/security-group
Length of output: 117
Script:
#!/bin/bash
# Verify that the security group configuration has the necessary output "security_group_id".
rg 'output "security_group_id"' infra/us-east-1/mgmt/atlantis/security-group
Length of output: 78
Script:
#!/bin/bash
# List all HCL files in the security group configuration directory to ensure we are not missing any files.
fd '\.hcl$' infra/us-east-1/mgmt/atlantis/security-group
Length of output: 118
Script:
#!/bin/bash
# Check the contents of the terragrunt.hcl file in the security group configuration directory for the output "security_group_id".
cat infra/us-east-1/mgmt/atlantis/security-group/terragrunt.hcl | rg 'output "security_group_id"'
Length of output: 99
Comment on lines
26
to
39
| inputs = { | ||
| name = local.name | ||
| instance_type = "t2.micro" | ||
|
|
||
|
|
||
| create_iam_instance_profile = true | ||
| iam_role_description = "IAM role for EC2 instance" | ||
| iam_role_policies = { | ||
| AdministratorAccess = "arn:aws:iam::aws:policy/AdministratorAccess" | ||
| } | ||
|
|
||
| subnet_id = dependency.vpc.outputs.public_subnets[0] | ||
|
|
||
| vpc_security_group_ids = [dependency.security_group.outputs.security_group_id] |
There was a problem hiding this comment.
The inputs block sets up the EC2 instance with a t2.micro instance type and an IAM role with AdministratorAccess. This is a potential security risk as it grants broad permissions to the EC2 instance. Recommend using a least privilege role specific to the instance's needs.
- AdministratorAccess = "arn:aws:iam::aws:policy/AdministratorAccess"
+ # Replace with a policy that follows the principle of least privilege
+ CustomLimitedAccess = "arn:aws:iam::aws:policy/CustomLimitedAccessPolicy"Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| inputs = { | |
| name = local.name | |
| instance_type = "t2.micro" | |
| create_iam_instance_profile = true | |
| iam_role_description = "IAM role for EC2 instance" | |
| iam_role_policies = { | |
| AdministratorAccess = "arn:aws:iam::aws:policy/AdministratorAccess" | |
| } | |
| subnet_id = dependency.vpc.outputs.public_subnets[0] | |
| vpc_security_group_ids = [dependency.security_group.outputs.security_group_id] | |
| inputs = { | |
| name = local.name | |
| instance_type = "t2.micro" | |
| create_iam_instance_profile = true | |
| iam_role_description = "IAM role for EC2 instance" | |
| iam_role_policies = { | |
| # Replace with a policy that follows the principle of least privilege | |
| CustomLimitedAccess = "arn:aws:iam::aws:policy/CustomLimitedAccessPolicy" | |
| } | |
| subnet_id = dependency.vpc.outputs.public_subnets[0] | |
| vpc_security_group_ids = [dependency.security_group.outputs.security_group_id] |
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit -->
|
atlantis apply |
This comment has been minimized.
This comment has been minimized.
|
atlantis unlock |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- infra/us-east-1/mgmt/atlantis/ec2/terragrunt.hcl
|
atlantis apply -d infra/us-east-1/mgmt/atlantis/ec2 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
atlantis apply -d infra/us-east-1/mgmt/atlantis/ec2 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
atlantis unlock |
|
Failed to delete PR locks |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
atlantis apply -d infra/us-east-1/mgmt/atlantis/alb |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- infra/us-east-1/mgmt/atlantis/alb/terragrunt.hcl (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- infra/us-east-1/mgmt/atlantis/alb/terragrunt.hcl
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis apply -d infra/us-east-1/mgmt/atlantis/alb |
This comment has been minimized.
This comment has been minimized.
|
atlantis show -d infra/us-east-1/mgmt/atlantis/key-pair |
|
|
atlantis apply |
This comment has been minimized.
This comment has been minimized.
|
atlantis unlock |
This comment has been minimized.
This comment has been minimized.
|
atlantis plan |
This comment has been minimized.
This comment has been minimized.
|
atlantis apply |
|
Ran Apply for 6 projects:
1. dir:
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- infra/us-east-1/mgmt/atlantis/alb/terragrunt.hcl (1 hunks)
- infra/us-east-1/mgmt/ecr/terragrunt.hcl (1 hunks)
Files skipped from review due to trivial changes (1)
- infra/us-east-1/mgmt/ecr/terragrunt.hcl
Files skipped from review as they are similar to previous changes (1)
- infra/us-east-1/mgmt/atlantis/alb/terragrunt.hcl
|
Ran Plan for 6 projects:
4. dir:
|
renebarbosafl
suggested changes
Jan 30, 2024
| project = local.environment_vars.locals.project | ||
| cidr_prefix = local.environment_vars.locals.cidr_prefix | ||
| tribe = local.account_vars.locals.tribe | ||
| zone_id = "Z10147571DRRDCJXSER5Y" |
There was a problem hiding this comment.
You can get this from dependency outputs. We are managing that zone using Terraform.
See: https://github.com/input-output-hk/sc-dev-platform/blob/main/infra/global/route53/zones/terragrunt.hcl
Comment on lines
+30
to
+35
| tags = { | ||
| Name = "${local.name}" | ||
| Tribe = "${local.tribe}" | ||
| Environment = "${local.env}" | ||
| Project = "${local.project}" | ||
| } |
There was a problem hiding this comment.
I don't think it's necessary. Terragrunt is adding these tags automatically.
See: https://github.com/input-output-hk/sc-dev-platform/blob/main/infra/terragrunt.hcl#L70
Comment on lines
+54
to
+60
| user_data = <<-EOF | ||
| #!/bin/bash | ||
| sudo yum update -y | ||
| sudo yum install -y docker | ||
| sudo service docker start | ||
| sudo usermod -a -G docker ec2-user | ||
| EOF |
There was a problem hiding this comment.
Where is the command to start the atlantis container itself?
How are you starting it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit