This repository was archived by the owner on Jun 10, 2024. It is now read-only.
split kubevela and kubevela-addons into separate modules #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CodeRabbit review skipped By default, CodeRabbit only reviews PRs on the default branch. If you wish to have PRs reviewed on additional branches, you can configure that under the repository settings in the UI. |
renebarbosafl
approved these changes
Oct 16, 2023
|
LGTM |
tshaynik
force-pushed
the
split-kubevela-module
branch
from
e451cfd to
8c3245f
Compare
|
State is reconciled across modules and applied. |
This was referenced Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to get around a bootstrapping issue in deploying kubevela for the first time, where the addons cannot be deployed because the CRDs (deployed as part of the kubevela helm chart) do not exist, and adding a dependency within the module does not work. This is a known issue with the kubectl provider.
This PR resolves the issue by splitting addons into a separate module, and declaring the dependency at the terragrunt level.