Fix ATMS verifier for circuit reusability across signature sets #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
approved these changes
Oct 21, 2025
Collaborator
iquerejeta
left a comment
iquerejeta
left a comment
There was a problem hiding this comment.
The new circuit logic looks good 👍
prover/src/signatures/schnorr.rs
Outdated
Comment on lines
101
to
105
| let is_verified = self.verify(ctx, signature, pk, msg)?; | ||
| self.ecc_gate | ||
| .main_gate | ||
| .assert_one(ctx, &is_verified)?; | ||
| Ok(()) |
Collaborator
There was a problem hiding this comment.
this assert verify is more expensive than previously, as you've replaced an assert_equal(free) by an is_equal.
Collaborator
Author
There was a problem hiding this comment.
good point
I refactored the code so that assert_equal is used for assert_verify function. Unfortunetely we still need is_equal for the version that returns value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, signature positions were enforced by circuit constraints, preventing the same compiled circuit from being used with different signature sets. This fix removes the positional constraints by always assigning dummy signatures for non-signers, allowing circuit reuse across different signing party combinations.