Use jsdom polyfill and update jest #2386
Conversation
NSeydoux
force-pushed
the
chore/jsdom-polyfill
branch
from
4a227c5 to
6c4e9dd
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ecbf668:
|
jest.setup.ts
Outdated
| @@ -0,0 +1 @@ | |||
| import "@inrupt/jest-jsdom-polyfills"; | |||
There was a problem hiding this comment.
| import "@inrupt/jest-jsdom-polyfills"; | |
| import "@inrupt/jest-jsdom-polyfills"; | |
missing trailing new line, and eslint may complain about license header.
There was a problem hiding this comment.
We currently don't run eslint on config files (none of them include the license header). Should we?
There was a problem hiding this comment.
Debatable? It does run in some repos, needs to be standardised as included or ignored in style configs
| (this.global.crypto.subtle as any) = (new Crypto()).subtle; | ||
| this.global.CryptoKey = CryptoKey; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Let's fix this in jest-jsdom-polyfills instead of using custom environments.
There was a problem hiding this comment.
This works in the polyfill (I have tested it locally, I was planning on merging this and revisiting after releasing the updated polyfills), but I couldn't get the Uint8Array thing to work in there, so for now I'm afraid the custom environment has to stay. We can revisit why, but I'd like to move on because this has been a time sink :)
There was a problem hiding this comment.
There was a problem hiding this comment.
Hm, okay; I suspect this is due to there being that JSDom UInt8Array issue
There was a problem hiding this comment.
I think this should've been released now, so this shouldn't be necessary anymore.
Instead of relying on Lerna to run tests across the repos, just use Jest picking a specific project or running them all.
Initially, the intent of this PR was just to use jsdom polyfills we provide to simplify the environment setup. However, it showed that we are currently not running our unit test using the browser jose bundle in the browser package, because we are using an older version of
jest. So this PR also looks at updating jest to the latest version.EDIT: a bunch of upgrades tacked on this PR:
ts-jest