Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude constants from type definitions #613

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Nov 16, 2020

We don't want people to use them directly, so they're undocumented,
but they should be available for apps that compile our TypeScript
themselves (like Angular apps, apparently).

This PR should fix #608.

  • I've added a unit test to test for potential regressions of this bug. N/A
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@Vinnl Vinnl requested review from pmcb55 and NSeydoux November 16, 2020 11:37
@Vinnl Vinnl self-assigned this Nov 16, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d66d993:

Sandbox Source
solid-client-sandbox Configuration

Copy link
Contributor

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just to note, the issue seems to have arisen via the exposure of this type definition in control.ts which references acp.accessControl directly:

export type WithLinkedAcpAccessControl<
  Resource extends WithServerResourceInfo = WithServerResourceInfo
> = Resource & {
  internal_resourceInfo: {
    linkedResources: {
      [acp.accessControl]: [string];
    };
  };
};

We don't want people to use them directly, so they're undocumented,
but they should be available for apps that compile our TypeScript
themselves.
@Vinnl Vinnl force-pushed the fix/608-exported-constants branch from 622fdd5 to d66d993 Compare November 16, 2020 12:48
@vercel vercel bot temporarily deployed to Preview November 16, 2020 12:48 Inactive
@Vinnl Vinnl merged commit 72c97c7 into master Nov 16, 2020
@Vinnl Vinnl deleted the fix/608-exported-constants branch November 16, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when building angular app with solid-client: Module '"../constants"' has no exported member 'acp'
2 participants