Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agenda and agendaupdate: add --details length redux #818

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelmhoffman
Copy link
Collaborator

Implements #791. Resubmission of accidentally closed pull request #817.

To eliminate the possibility of conflicts between length and end_date/end_time, this raises NotImplementedError if input is supplied with both of the fields.

In the future, the following would be better conflict resolution approaches:

  1. allow both end fields and length field long as they are consistent in each row
  2. conflict resolution by command-line option (e.g. prefer end fields or prefer length field)
  3. conflict resolution interactively

@michaelmhoffman
Copy link
Collaborator Author

@dbarnett Would you like to review this pull request? If you would rather I just merge it, I can do that.

Copy link
Collaborator

@dbarnett dbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@dbarnett
Copy link
Collaborator

dbarnett commented Dec 18, 2024

Sorry I got busy and didn't see this at first!

LMK if you need anything else here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants