coherence change detection: bugfix + folium plot #49
Conversation
mgovorcin
commented
Dec 22, 2022
mgovorcin
commented
- fix few bugs in plotting function plot_ccd
- replaced ax.invert with mintpy.utils.plot.auto_flip_direction
- applied Yunjun commits - make the notebook shorter
change method option definition from: 'diff', 'hist', 'ratio' to 'difference', histogram_matching', 'ratio' make the code for plot function shorter and add option to flip axes if option orbit_direction used
Little cleanup following PEP8 style and renaming of variables to fit snake_case style
- replaced "ax.invert_yaxis()" with mintpy.utils.plot.auto_flip_direction
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-12-22T01:19:49Z I suggest to merge this cell with the cell below, for compactness. |
|
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-12-22T01:19:50Z Line #174. for i in range(0, nimg): Use mgovorcin commented on 2022-12-22T03:22:18Z applied |
|
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-12-22T01:19:51Z Line #6. stack = os.path.join(work_dir, 'inputs/ifgramStack.h5') I would suggest using mgovorcin commented on 2022-12-22T03:22:31Z done |
|
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-12-22T01:19:51Z Line #35. for i, method in enumerate(methods): Use mgovorcin commented on 2022-12-22T03:22:43Z applied |
|
Thank you @mgovorcin. Looks great overall. I only have a few minor suggestions on details. |
|
applied View entire conversation on ReviewNB |
|
done View entire conversation on ReviewNB |
|
applied View entire conversation on ReviewNB |
|
Thanks @mgovorcin. One last thing: The google earth screen shot is very intuitive. I would highly recommend keeping it. from IPython.display import Image
Image("Fernandina_eruptionSep2017.png") |
There was a problem hiding this comment.
Thank you @mgovorcin. The folium plot is beautiful! Looks all good to me, squash and merge whenever you are ready please.
yunjunz
changed the title
