dem_error
w/ phase velocity: rm all-zero column in design matrix
#905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
dem_error.py --phase-velocity
: remove the all-zero column in the design matrixG
and the all-one column in the design matrixG0
, as suggested by @mirzaees in abnormal large residual fromdem_error
fortimeseries_rms
#892. This is because the constant intercept term of the polynomial is not estimated in the phase velocity minimization scenario. Including this all-zero column inG
could sometimes introduce abnormally large eigenvalues in the least-squares inversion, resulting in an unrealistic TS residual.Reminders