Remove max_input_length from model.encode
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsarti
added a commit
that referenced
this pull request
Oct 30, 2023
* origin/main: Remove `max_input_length` from `model.encode` (#227)
gsarti
added a commit
that referenced
this pull request
Oct 30, 2023
* origin/main: Attributed behavior for contrastive step functions (#228) Fix command for installing pre-commit hooks. (#229) Remove `max_input_length` from `model.encode` (#227) Migrate to `ruff format` (#225) Remove contrast_target_prefixes from contrastive step functions (#224) Step functions fixes, add `in_context_pvi` (#223) Format fixes, add Attanasio et al. (2023) to readme Add Sequential IG method (#222) Fix LIME and Occlusion outputs (#220) Update citation information Bump dependencies Add end_pos for contrast_targets_alignments Fix dummy output viz in console Minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the logic to impose a
max_lengthin absence of pre-specified max input size in model configuration. Closes #221.