Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-English program captions aren't displaying correctly #87

Open
jbmorley opened this issue Jan 26, 2022 · 9 comments
Open

Non-English program captions aren't displaying correctly #87

jbmorley opened this issue Jan 26, 2022 · 9 comments
Labels
bug Something isn't working
Milestone

Comments

@jbmorley
Copy link
Collaborator

The 'Strip Poker' app is a good example of this. 🤦🏻‍♂️😬

@jbmorley
Copy link
Collaborator Author

Interestingly, the Strip Poker app language selection doesn't seem to be stable: sometimes we get an English language string, other times we get the garbled Russian string.

@jbmorley
Copy link
Collaborator Author

jbmorley commented Jan 27, 2022

While I'm curious to try fixing this, it's definitely not required for 1.0.0. Pushing to future.

@jbmorley jbmorley added this to the Future milestone Jan 27, 2022
@jbmorley
Copy link
Collaborator Author

image

@jbmorley
Copy link
Collaborator Author

It's now really easy to see this with the new AIF viewer.

@jbmorley jbmorley added the bug Something isn't working label Feb 21, 2022
@jbmorley jbmorley changed the title Russian program captions aren't displaying correctly. Non-English program captions aren't displaying correctly Mar 11, 2022
@tomsci
Copy link
Collaborator

tomsci commented Sep 7, 2024

Do you have a link for this now @jbmorley so I can see what's going on?

@jbmorley
Copy link
Collaborator Author

jbmorley commented Sep 8, 2024

@tomsci
Copy link
Collaborator

tomsci commented Sep 10, 2024

Confirmed, the Russian AIF caption is encoded in Windows-1251, and not Window-1252 like pretty much everything else. Which is understandable since 1252 doesn't have Cyrillic characters in it. It would be easy enough to fix in this one specific case, but I'm not sure how it should be handled generally. This particular app doesn't seem to have any actual Russian strings in it other than the AIF caption, so how eg a multilingual app should be handled, unsure.

@jbmorley
Copy link
Collaborator Author

jbmorley commented Sep 10, 2024 via email

@kapfab
Copy link

kapfab commented Sep 11, 2024

Just my two cents…

The OPL CAPTION keyword only support 24 languages, most of which can be safely encoded in Windows-1252.
Out of these 24, I guess only Russian (1251) and Hungarian (1250), and maybe Turkish (1254), could need a specific code page mapping.

But I’m not even sure a single EPOC device ever left the factory with support for something else than Windows-1252, so considering a caption could be encoded differently might not be safe.
Localization apps brought support for a few other codepages, but that was not necessarily expected by Psion when they added the CAPTION keyword.

For the ÑòðèïÏîêåðСтрипПокерStripPoker case, it might just be the Russian developer had their OS software-localized and used cyrillic characters instead of the expected latin ones. There it was Windows-1251 but could have been KOI-8R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants