Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Rx bits #670

Closed
wants to merge 1 commit into from
+1 −24
Closed

Remove unused Rx bits #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Packages/ConfCore/ConfCore/ConfCoreExports.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,5 @@

@_exported import Foundation
@_exported import RealmSwift
@_exported import RxSwift
@_exported import RxCocoa
@_exported import RxRealm
@_exported import Siesta
@_exported import Transcripts
3 changes: 0 additions & 3 deletions WWDC/AppCoordinator+Bookmarks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@
import Cocoa
import AVFoundation
import PlayerUI
import RxSwift
import RxCocoa
import RealmSwift
import RxRealm
import ConfCore

extension AppCoordinator: PUITimelineDelegate, VideoPlayerViewControllerDelegate {
Expand Down
1 change: 0 additions & 1 deletion WWDC/AppCoordinator+SessionActions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import Cocoa
import RealmSwift
import RxSwift
import ConfCore
import PlayerUI
import EventKit
Expand Down
1 change: 0 additions & 1 deletion WWDC/AppCoordinator+SessionTableViewContextMenuActions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import Cocoa
import RealmSwift
import RxSwift
import ConfCore
import PlayerUI

Expand Down
1 change: 0 additions & 1 deletion WWDC/AppCoordinator+Shelf.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import Cocoa
import RealmSwift
import RxSwift
import ConfCore
import PlayerUI
import CoreMedia
Expand Down
1 change: 0 additions & 1 deletion WWDC/AppCoordinator+UserActivity.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import Cocoa
import RealmSwift
import RxSwift
import ConfCore
import PlayerUI

Expand Down
1 change: 1 addition & 0 deletions WWDC/ExploreTabProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Cocoa
import SwiftUI
import Combine
import ConfCore
import RxSwift

final class ExploreTabProvider: ObservableObject {
let storage: Storage
Expand Down
4 changes: 0 additions & 4 deletions WWDC/PreferencesCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//

import Cocoa
import RxCocoa
import RxSwift
import ConfCore

enum PreferencesTab: Int, WWDCTab {
Expand All @@ -18,8 +16,6 @@ enum PreferencesTab: Int, WWDCTab {

final class PreferencesCoordinator {

private let disposeBag = DisposeBag()

private let windowController: PreferencesWindowController

private let tabController: WWDCTabViewController<PreferencesTab>
Expand Down
4 changes: 0 additions & 4 deletions WWDC/RelatedSessionsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//

import Cocoa
import RxSwift
import RxCocoa

private extension NSUserInterfaceItemIdentifier {
static let sessionItem = NSUserInterfaceItemIdentifier("sessionCell")
Expand Down Expand Up @@ -37,8 +35,6 @@ final class RelatedSessionsViewController: NSViewController {
static let padding: CGFloat = 24
}

private let disposeBag = DisposeBag()

var sessions: [SessionViewModel] = [] {
didSet {
collectionView.reloadData()
Expand Down
4 changes: 0 additions & 4 deletions WWDC/SessionDetailsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,13 @@
//

import Cocoa
import RxSwift
import RxCocoa

final class SessionDetailsViewController: WWDCWindowContentViewController {

private struct Metrics {
static let padding: CGFloat = 46
}

private let disposeBag = DisposeBag()

let listStyle: SessionsListStyle

var viewModel: SessionViewModel? {
Expand Down
2 changes: 0 additions & 2 deletions WWDC/SessionTableCellView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//

import Cocoa
import RxSwift
import RxCocoa

final class SessionTableCellView: NSTableCellView {

Expand Down