Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent PiP / full screen state, improved full screen transition #710

Merged
merged 7 commits into from
May 30, 2024
Merged

Consistent PiP / full screen state, improved full screen transition #710

merged 7 commits into from
May 30, 2024

Conversation

insidegui
Copy link
Owner

Addresses this, originally reported by @allenhumphreys in #695:

This isn't from your work, but I noticed full screen mode doesn't use the external player status which feels inconsistent. In full screen, you just see the video poster image. This is likely because the entire player view moves to the full screen window.

@insidegui insidegui marked this pull request as ready for review May 30, 2024 20:18
@insidegui insidegui merged commit 039ba89 into master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@insidegui