Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awkward by/strata phrasing #358

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jtalboys
Copy link
Collaborator

@jtalboys jtalboys commented Nov 14, 2024

What changes are proposed in this pull request?

Provide more detail here as needed.

Went with the phrasing I suggested in #325, let me know what you think - happy to brainstorm a little more if it's still not what we're after

closes #325


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@jtalboys jtalboys requested a review from ddsjoberg November 14, 2024 16:30
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtalboys !

@ddsjoberg ddsjoberg merged commit 5e3bb1f into insightsengineering:main Nov 19, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@jtalboys jtalboys deleted the 325-update-phrasing branch November 19, 2024 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update this awkward phrasing in the help file (could apply to multiple files)
2 participants