-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct failure due to timezone handling #750
Conversation
Code Coverage Summary
Diff against main
Results for commit: b31640d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 54 suites 2m 40s ⏱️ Results for commit b31640d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting issue! I did not know that the timezone would impact the date
Unit Test Performance DifferenceAdditional test case details
Results for commit 4082e77 ♻️ This comment has been updated with latest results. |
correct error in integration tests.
In the listings, the time reported should be the time of the event at the location where the event was recorded. Using base function changes the result depending on the time zone of the computer. Use
lubridate
to circumvent the issue.thank you for the review.