Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct failure due to timezone handling #750

Merged
merged 12 commits into from
May 21, 2024
Merged

correct failure due to timezone handling #750

merged 12 commits into from
May 21, 2024

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented May 15, 2024

correct error in integration tests.

In the listings, the time reported should be the time of the event at the location where the event was recorded. Using base function changes the result depending on the time zone of the computer. Use lubridate to circumvent the issue.

thank you for the review.

@BFalquet BFalquet requested a review from clarkliming as a code owner May 15, 2024 11:59
Copy link
Contributor

github-actions bot commented May 15, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/ael01_nollt.R                 10       2  80.00%   54-56
R/ael02.R                       27       0  100.00%
R/aet01.R                       98       1  98.98%   172
R/aet01_aesi.R                 148       1  99.32%   214
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet05_all.R                   11       0  100.00%
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       81       7  91.36%   83, 87-91, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   210-213
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      181      25  86.19%   142, 158, 177-179, 296-299, 303-306, 333, 337, 349, 351, 363, 380-382, 404-417
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3306     112  96.61%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -11      +1  -15.24%
R/ael02.R                      +27       0  +100.00%
R/aet01.R                       +4       0  +0.04%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                      -15      +6  -7.60%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +97     +25  -13.81%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +235     +37  -0.95%

Results for commit: b31640d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 15, 2024

Unit Tests Summary

  1 files   54 suites   2m 40s ⏱️
247 tests 176 ✅  71 💤 0 ❌
479 runs  306 ✅ 173 💤 0 ❌

Results for commit b31640d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting issue! I did not know that the timezone would impact the date

Copy link
Contributor

github-actions bot commented May 16, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
assertions 👶 $+0.03$ assert_valid_var.POSIXct_works_as_expected

Results for commit 4082e77

♻️ This comment has been updated with latest results.

@clarkliming clarkliming self-requested a review May 17, 2024 02:18
R/utils.R Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming May 17, 2024 18:41
@BFalquet BFalquet merged commit 67a59ad into main May 21, 2024
28 checks passed
@BFalquet BFalquet deleted the tz_failure@main branch May 21, 2024 07:38
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants