Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable URL encoding for badge links #33

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Nov 7, 2023

URL encode branch names.
Fixes #32

@cicdguy cicdguy self-assigned this Nov 7, 2023
@cicdguy cicdguy requested a review from a team as a code owner November 7, 2023 12:35
Copy link

github-actions bot commented Nov 7, 2023

badge

Code Coverage Summary (test-missing-lines.xml)

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  ---------------
all_lines_covered.py       10       0  100.00%
miss_at_start.py           10       2  80.00%   1-3
miss_at_end.py             10       2  80.00%   9-10
single_line_gaps.py        10       3  70.00%   3, 5, 9
multi_line_gaps.py         10       7  30.00%   4-5, 7-9, 15-18
unsorted_lines.py          10       5  50.00%   4, 3, 8-9, 6
no_lines.py                 0       0  0.00%
single_line.py              1       1  0.00%    4
TOTAL                      61      20  51.25%

Results for commit: 7f51dcd

Minimum allowed coverage is 50%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Nov 7, 2023

badge

Code Coverage Summary (test-no-branch.xml)

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------
Main.java                            11       0  100.00%
search/BinarySearch.java             12       1  91.67%   24
search/ISortedArraySearch.java        0       0  100.00%
search/LinearSearch.java              7       2  71.43%   19-24
TOTAL                                30       3  90.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7f51dcd

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

@cicdguy cicdguy merged commit cdeaeb8 into main Nov 7, 2023
5 checks passed
@cicdguy cicdguy deleted the fix/url-encoded-badge-links branch November 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Badge Display Issue with Branch Names Containing URL-Unsafe Characters
2 participants