Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatted values different from cell values #988

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Fix formatted values different from cell values #988

merged 7 commits into from
Feb 6, 2025

Conversation

Melkiades
Copy link
Contributor

Fix #987 (variables handling to improve)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Tests Summary

    1 files     28 suites   1m 40s ⏱️
  221 tests   221 ✅ 0 💤 0 ❌
1 588 runs  1 588 ✅ 0 💤 0 ❌

Results for commit c4af0eb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Tabulation framework 💔 $19.79$ $+1.12$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Result Data Frames 👶 $+0.16$ make_ard_works_when_printed_format_differs_from_cell_values

Results for commit 2f7825e

♻️ This comment has been updated with latest results.

edelarua
edelarua approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Just a few suggestions from me to make the messaging more concise. Thanks Davide :)

@edelarua
Copy link
Contributor

If you need to make more changes to fix the tests and need a re-review let me know!!

Melkiades and others added 5 commits January 31, 2025 09:35
@Melkiades @edelarua
Update R/tt_as_df.R
46a647e 
Co-authored-by: Emily de la Rua <edelarua@uwaterloo.ca>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades @edelarua
Update R/tt_as_df.R
92e6719 
Co-authored-by: Emily de la Rua <edelarua@uwaterloo.ca>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades @edelarua
Update R/tt_as_df.R
a0bc83b 
Co-authored-by: Emily de la Rua <edelarua@uwaterloo.ca>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades
fix tests
b04662d
@Melkiades
Merge branch 'main' into 987_fixes_and_corrections_ARD@main
c4af0eb
@Melkiades Melkiades enabled auto-merge (squash) February 6, 2025 17:22
@Melkiades Melkiades merged commit 33aec5a into main Feb 6, 2025
26 checks passed
@Melkiades Melkiades deleted the 987_fixes_and_corrections_ARD@main branch February 6, 2025 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edelarua edelarua edelarua approved these changes

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
ARD sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

as_result_df diffs noticed in ARD output
2 participants
@Melkiades @edelarua