-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lookup-refs #989
Remove lookup-refs #989
Conversation
Unit Tests Summary 1 files 28 suites 1m 37s ⏱️ Results for commit b553f2b. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 7d89c6f ♻️ This comment has been updated with latest results. |
please don't merge this yet, until discussion resolved in https://github.com/insightsengineering/coredev-tasks/issues/609 |
@shajoezhu we provided an explanation for this change in that conversation that you linked. |
@shajoezhu I see a positive review in rtables.officer on a similar PR insightsengineering/rtables.officer#35 |
i m blocking this for now. thanks @m7pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @m7pr
Code Coverage Summary
Diff against main
Results for commit: b553f2b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install
,renv::install
andremotes::install
.With development dependencies specified in CI Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.
formatters was the only package on lookup-refs. It is a dependency required at the version available on CRAN or higher.