Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

145 create qenvs empty #156

Merged
merged 22 commits into from
Dec 4, 2023
Merged

145 create qenvs empty #156

merged 22 commits into from
Dec 4, 2023

Conversation

chlebowa
Copy link
Contributor

Closes #145

I suggest we take this opportunity to also do #150

@chlebowa chlebowa added the core label Oct 24, 2023
R/qenv-constructor.R Outdated Show resolved Hide resolved
@m7pr
Copy link
Contributor

m7pr commented Oct 30, 2023

Should we update NEWS + bump version, so that maybe there is a way to display info on deprecations https://github.com/insightsengineering/teal.code/pull/156/files#r1376050705?

R/qenv-constructor.R Outdated Show resolved Hide resolved
@chlebowa chlebowa marked this pull request as ready for review November 30, 2023 14:46
Copy link
Contributor

github-actions bot commented Nov 30, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        16      13  18.75%   46-89
R/qenv-eval_code.R          52       2  96.15%   101, 110
R/qenv-get_code.R           18       0  100.00%
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-replace_code.R        8       0  100.00%
R/qenv-show.R                1       1  0.00%    13
R/qenv-within.R              7       0  100.00%
R/utils.R                   12       0  100.00%
TOTAL                      213      16  92.49%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  -------
R/qenv-constructor.R       +4     +13  -81.25%
TOTAL                      +4     +13  -6.08%

Results for commit: e8031fa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Aleksander Chlebowski and others added 3 commits November 30, 2023 16:16
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Unit Tests Summary

    1 files    10 suites   0s ⏱️
  68 tests   68 ✔️ 0 💤 0
144 runs  144 ✔️ 0 💤 0

Results for commit e8031fa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv_constructor 💀 $0.01$ $-0.01$ Initializing_qenv_with_code_only_creates_corresponding_warnings_and_messages_slots
qenv_constructor 👶 $+0.01$ constructor_returns_qenv
qenv_constructor 💀 $0.01$ $-0.01$ constructor_returns_qenv_if_nothing_is_specified
qenv_constructor 💀 $0.01$ $-0.01$ new_qenv_allows_to_pass_irreproducible_env_and_code
qenv_constructor 💀 $0.06$ $-0.06$ new_qenv_fails_if_code_is_provided_but_not_environment
qenv_constructor 💀 $0.01$ $-0.01$ new_qenv_works_with_code_being_character
qenv_constructor 💀 $0.01$ $-0.01$ new_qenv_works_with_code_being_expression
qenv_constructor 💀 $0.01$ $-0.01$ new_qenv_works_with_code_being_length_1
qenv_constructor 💀 $0.01$ $-0.01$ new_qenv_works_with_code_being_quoted_expression
qenv_constructor 👶 $+0.01$ parent_of_qenv_environment_is_locked
qenv_constructor 💀 $0.00$ $-0.00$ provided_environment_is_copied_so_the_change_of_the_environment_won_t_affect_qenv

Results for commit 83155e5

♻️ This comment has been updated with latest results.

@chlebowa
Copy link
Contributor Author

chlebowa commented Dec 1, 2023

Great catch @pawelru 👏

@pawelru
Copy link
Contributor

pawelru commented Dec 1, 2023

  1. There is one more new_quenv in docs:
    #' `q <- new_qenv()` \cr
  2. Please add NEWS entry. It's a big change.

@chlebowa
Copy link
Contributor Author

chlebowa commented Dec 1, 2023

  1. There is one more new_quenv in docs:

Thanks for catching it 👍

  1. Please add NEWS entry. It's a big change.

done 👍

@gogonzo gogonzo self-assigned this Dec 4, 2023
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

R/qenv-constructor.R Outdated Show resolved Hide resolved
@chlebowa chlebowa enabled auto-merge (squash) December 4, 2023 14:42
@chlebowa chlebowa merged commit 9f17086 into main Dec 4, 2023
25 checks passed
@chlebowa chlebowa deleted the 145_create_qenvs_empty@main branch December 4, 2023 14:45
averissimo added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow to specify initial env and a code
4 participants