Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code masking #160

Merged
merged 14 commits into from
Nov 9, 2023
Merged

add code masking #160

merged 14 commits into from
Nov 9, 2023

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Nov 7, 2023 •
edited
Loading

Added private function replace_code to facilitate manipulating contents of @code.

@chlebowa chlebowa added the core label Nov 7, 2023
@chlebowa chlebowa requested review from gogonzo and pawelru November 7, 2023 14:11
@chlebowa
Copy link
Contributor Author

chlebowa commented Nov 7, 2023

Frankly, the more I look at the example, the more uncomfortable I feel exporting this function.

@chlebowa
Copy link
Contributor Author

chlebowa commented Nov 7, 2023

The function name is up for debate. I even considered set_code but that would imply that the whole slot can be modified.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------
R/include_css_js.R               7       7  0.00%    12-20
R/qenv-concat.R                 10       0  100.00%
R/qenv-constructor.R            12       0  100.00%
R/qenv-eval_code.R              52       2  96.15%   100, 109
R/qenv-get_code.R               18       0  100.00%
R/qenv-get_var.R                19       0  100.00%
R/qenv-get_warnings.R           24       0  100.00%
R/qenv-join.R                   46       0  100.00%
R/qenv-replace_code.R            8       0  100.00%
R/qenv-show.R                    1       1  0.00%    16
R/qenv-within.R                  7       0  100.00%
R/utils-code_dependency.R      190       7  96.32%   37, 42, 252-253, 317-320
R/utils.R                       12       0  100.00%
TOTAL                          406      17  95.81%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/qenv-replace_code.R       +8       0  +100.00%
TOTAL                       +8       0  +0.08%

Results for commit: 47b995b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

Unit Tests Summary

    1 files    11 suites   1s ⏱️
  99 tests   99 ✔️ 0 💤 0 ❌
192 runs  192 ✔️ 0 💤 0 ❌

Results for commit 47b995b.

♻️ This comment has been updated with latest results.

gogonzo
gogonzo reviewed Nov 7, 2023
View reviewed changes
chlebowa and others added 2 commits November 7, 2023 17:52
@chlebowa @gogonzo
update tests with review comments
55f0b15 
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
linter
1528570
@chlebowa chlebowa enabled auto-merge (squash) November 8, 2023 14:06
gogonzo
gogonzo approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Please remove replace_code from pkgdown

_pkgdown.yml
@@ -27,6 +27,7 @@ reference:
- concat
- dev_suppress
- eval_code
- replace_code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal docs shouldn't be listed in pkgdown.yml, please remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one I always forget 🙄

@chlebowa chlebowa merged commit b7bb681 into main Nov 9, 2023
@chlebowa chlebowa deleted the mask_code@main branch November 9, 2023 09:27
This was referenced Nov 9, 2023
Closed
Merged
chlebowa added a commit that referenced this pull request Nov 9, 2023
@chlebowa
remove replace_code from pkgdown (#162)
bdde709 
minor fix after #160
@chlebowa chlebowa mentioned this pull request Nov 10, 2023
Merged
chlebowa added a commit that referenced this pull request Dec 14, 2023
@chlebowa
remove replace_code function (#163)
3d4fd3c 
Rolls back #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelru pawelru pawelru left review comments

@gogonzo gogonzo gogonzo approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chlebowa @gogonzo @pawelru