Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

94 get_var inherits = FALSE #186

Merged
merged 3 commits into from
Dec 14, 2023
Merged

94 get_var inherits = FALSE #186

merged 3 commits into from
Dec 14, 2023

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Dec 14, 2023

Closes #94
Added inherits = FALSE to get call in get_var.
Added unit tests.

@chlebowa chlebowa changed the title get_var inherits = FALSE 94 get_var inherits = FALSE Dec 14, 2023
@chlebowa chlebowa changed the title 94 get_var inherits = FALSE 94 get_var inherits = FALSE Dec 14, 2023
@chlebowa chlebowa added the core label Dec 14, 2023
Copy link
Contributor

github-actions bot commented Dec 14, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        16      13  18.75%   54-93
R/qenv-eval_code.R          52       2  96.15%   100, 109
R/qenv-get_code.R           20       0  100.00%
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-replace_code.R       10       0  100.00%
R/qenv-show.R                1       1  0.00%    19
R/qenv-within.R              8       0  100.00%
R/utils.R                   10       0  100.00%
TOTAL                      216      16  92.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6aeaccc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Tests Summary

    1 files    10 suites   0s ⏱️
  69 tests   69 ✔️ 0 💤 0
141 runs  141 ✔️ 0 💤 0

Results for commit 6aeaccc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv_get_var 👶 $+0.01$ get_var_and_only_returns_objects_from_qenv_not_parent_environment_s_

Results for commit b9eec5d

♻️ This comment has been updated with latest results.

@chlebowa
Copy link
Contributor Author

Questions:

  1. Should get_var return NULL or raise error when variable does not exist? Currently prints message and returns NULL.
  2. Should we remove get_var altogether as per this comment? May require a separate issue.

@chlebowa chlebowa merged commit f7a5911 into main Dec 14, 2023
21 checks passed
@chlebowa chlebowa deleted the 94_inherits_FALSE@main branch December 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rethink get with inherits = TRUE
2 participants