qenv warnings #465
Merged
qenv warnings #465
+141
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/tm_g_bivariate.R
Outdated
| @@ -370,7 +373,7 @@ srv_g_bivariate <- function(id, | |||
|
|
|||
| anl_merged_q <- reactive({ | |||
| req(anl_merged_input()) | |||
| teal.code::new_qenv(tdata2env(data), code = get_code(data)) %>% | |||
| teal.code::new_qenv(tdata2env(data), code = teal.data::get_code(data)) %>% | |||
There was a problem hiding this comment.
So get_code.tdata lives in teal so do we need teal.data:: here? Would be really sad if we do...
There was a problem hiding this comment.
…into 63_warnings@teal_refactor@main
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com> Signed-off-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
| @@ -316,7 +316,10 @@ ui_distribution <- function(id, ...) { | |||
| ) | |||
| ) | |||
| ), | |||
| forms = teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code"), | |||
| forms = tagList( | |||
| teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"), | |||
There was a problem hiding this comment.
Some are id warnings others warning
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com> Signed-off-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Signed-off-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
…actor@main" and "origin/63_warnings@teal_refactor@main"
8 tasks
21 tasks
added 7 commits
October 13, 2022 10:52
simplify warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to insightsengineering/teal.code#63
teal.widgets::verbatim_popup_uiandteal.widgets::verbatim_popup_srvto account for warnings in the modules.Please test with example apps.