Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teal refactor #294

Merged
merged 13 commits into from
Nov 8, 2022
Merged

Teal refactor #294

merged 13 commits into from
Nov 8, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Oct 27, 2022 •
edited
Loading

mhallal1 and others added 5 commits September 8, 2022 08:55
@mhallal1 @Polkas @danielinteractive
data instead of datasets (#278)
15ed0b7 
* scripts

* tests

* docs

* snaps

* isolate

* remove print

* isolate

* with_filter

* reactive tests

* Update app.R

* fix

* remove MockDatasets

* check filter_panel_api

Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
update to use tdata class (#281)
09ca4a6
Merge branch 'main' into teal_refactor@main
cda717f
Merge branch 'main' into teal_refactor@main
98bb42e
Merge 98bb42e into 0f70531
15d0cc3
@nikolas-burkoff nikolas-burkoff mentioned this pull request Oct 27, 2022
Closed
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022 •
edited
Loading

Unit Tests Summary

  1 files  15 suites   23s ⏱️
56 tests 34 ✔️ 22 💤 0 ❌
76 runs  54 ✔️ 22 💤 0 ❌

Results for commit 5e4f7a8.

♻️ This comment has been updated with latest results.

Nikolas Burkoff and others added 4 commits October 28, 2022 10:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           156     113  27.56%   248-383
R/assaySpec.R            44      36  18.18%   103-142
R/barplot.R             169     136  19.53%   40-64, 123-259
R/boxplot.R             172     144  16.28%   41-65, 119-260
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 215-282
R/forestplot.R          197     172  12.69%   60-91, 147-312
R/geneSpec.R            255     153  40.00%   153-168, 297-481
R/km.R                  189     158  16.40%   63-92, 153-307
R/pca.R                 355     272  23.38%   35-55, 163-464
R/quality.R             298     228  23.49%   18-109, 203-431
R/sampleVarSpec.R       232     103  55.60%   290, 309-315, 321-328, 330, 338-350, 352-353, 355, 358, 366-370, 372-387, 392-416, 419-423, 425, 432-442, 444-445, 453, 498-515
R/scatterplot.R         167     137  17.96%   40-64, 122-258
R/utils.R                16       5  68.75%   74-78
R/volcanoplot.R         193     163  15.54%   35-56, 111-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2551    1886  26.07%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/adtteSpec.R            -1      -1  +0.18%
R/barplot.R              +3      +3  -0.35%
R/boxplot.R              +3      +3  -0.29%
R/experimentSpec.R       -3      -2  +0.12%
R/forestplot.R           +3      +3  -0.20%
R/km.R                   +3      +3  -0.26%
R/pca.R                  +3      +3  -0.20%
R/quality.R              +3      +3  -0.24%
R/scatterplot.R          +3      +3  -0.33%
R/volcanoplot.R          +2      +2  -0.16%
TOTAL                   +19     +20  -0.24%

Results for commit: 8a524bf

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@nikolas-burkoff nikolas-burkoff enabled auto-merge (squash) November 8, 2022 09:43
@nikolas-burkoff nikolas-burkoff merged commit 1523550 into main Nov 8, 2022
@nikolas-burkoff nikolas-burkoff deleted the teal_refactor@main branch November 8, 2022 09:53
@donyunardi donyunardi mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolas-burkoff @danielinteractive @mhallal1