Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the amount of spelling issues / WORDLIST #310

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jun 30, 2023

The follow-up after https://github.com/insightsengineering/coredev-tasks/issues/235

Final spelling::spell_check_package()

WORD        FOUND IN
Bové       teal.modules.hermes-package.Rd:21
Forkers     README.md:51,61,63
funder      teal.modules.hermes-package.Rd:43
hermes      description:1
            NEWS.md:1,7,9,19,26,38
            README.md:1
Hoffmann    teal.modules.hermes-package.Rd:43
Lyndsee     teal.modules.hermes-package.Rd:34
Midori      teal.modules.hermes-package.Rd:34
pre         sampleVarSpecServer.Rd:29
reactives   multiSampleVarSpecServer.Rd:25
repo        README.md:9,15,59,63
RNAseq      README.md:1
Sabanés    teal.modules.hermes-package.Rd:21
UI          adtteSpecInput.Rd:16
            adtteSpecServer.Rd:24,170
            assaySpecInput.Rd:16
            assaySpecServer.Rd:87
            experimentSpecInput.Rd:19,28
            experimentSpecServer.Rd:21,134
            geneSpecInput.Rd:46
            geneSpecServer.Rd:23,109
            h_gene_data.Rd:30
            module_arguments.Rd:8
            multiSampleVarSpecServer.Rd:11
            sampleVarSpecInput.Rd:22
            sampleVarSpecServer.Rd:126
            tm_g_barplot.Rd:58
            tm_g_boxplot.Rd:58
            tm_g_forest_tte.Rd:97
            tm_g_km.Rd:79
            tm_g_pca.Rd:44
            tm_g_quality.Rd:44
            tm_g_scatterplot.Rd:58
            tm_g_volcanoplot.Rd:51
            Getting_Started.Rmd:30,34,36

@m7pr m7pr added documentation Improvements or additions to documentation core labels Jun 30, 2023
@m7pr m7pr requested review from gogonzo and pawelru June 30, 2023 13:55
@m7pr m7pr self-assigned this Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

Unit Tests Summary

  1 files  15 suites   31s ⏱️
56 tests 43 ✔️ 13 💤 0
85 runs  72 ✔️ 13 💤 0

Results for commit ed9a20a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks please keep Kaplan-Meier as normal text, also ad-hoc or where the hoc was for

@m7pr
Copy link
Contributor Author

m7pr commented Jun 30, 2023

@danielinteractive I reverted back Kaplan-Meier. For the hoc and ad-hoc it no longer is a spelling issue. It was just removed from the WORDLIST but no ingeretion in the content of the package was provided

@m7pr m7pr requested a review from danielinteractive June 30, 2023 15:29
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m7pr !

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           156     113  27.56%   248-383
R/assaySpec.R            44      36  18.18%   103-142
R/barplot.R             169     136  19.53%   40-64, 123-259
R/boxplot.R             172     144  16.28%   41-65, 119-260
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 215-282
R/forestplot.R          197     172  12.69%   60-91, 147-312
R/geneSpec.R            255     153  40.00%   153-168, 297-481
R/km.R                  189     158  16.40%   63-92, 153-307
R/pca.R                 355     272  23.38%   35-55, 163-464
R/quality.R             298     228  23.49%   18-109, 203-431
R/sampleVarSpec.R       232     103  55.60%   291, 310-316, 322-329, 331, 339-351, 353-354, 356, 359, 367-371, 373-388, 393-417, 420-424, 426, 433-443, 445-446, 454, 499-516
R/scatterplot.R         167     137  17.96%   40-64, 122-258
R/utils.R                16       5  68.75%   74-78
R/volcanoplot.R         193     163  15.54%   35-56, 111-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2551    1886  26.07%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7b23f86

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr merged commit a1f283f into main Jun 30, 2023
@m7pr m7pr deleted the update_wordlist@main branch June 30, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants