optional height and width arguments to the append_plot method #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polkas
changed the title
Code Coverage SummaryResults for commit: a3bfb3f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
mhallal1
reviewed
Jul 5, 2022
Comment on lines
+42
to
+48
| testthat::test_that("append_plot accepts a ggplot with a dim", { | ||
| testthat::expect_error( | ||
| ReportCard$new()$append_plot(ggplot2::ggplot(iris), c(1000L, 100L)), | ||
| regexp = NA | ||
| ) | ||
| }) | ||
|
|
There was a problem hiding this comment.
please add a test case with no dim added (what is the expected output) and with wrong dim input.
There was a problem hiding this comment.
They are already there nevertheless in the lower level PictureBlock class.
I added additional tests to check strictly the size in pixels of the files.
mhallal1
reviewed
Jul 5, 2022
mhallal1
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
tested with insightsengineering/teal.widgets#63 (review) and working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #99
add optional height and width arguments to the append_plot method of the ReportCard