-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reporter around show r code #159
Conversation
Code Coverage Summary
Results for commit: ed814c0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
@BLAZEWIM thank you for your time. Truly there was a warning with unhelpful message, the css file path was wrong. I just fix it:) Regarding "Include Show R Code" -> "Include R Code", I treat the "Show R Code" as a brand/product name. |
@@ -18,6 +18,7 @@ Imports: | |||
bslib, | |||
checkmate, | |||
grid, | |||
htmltools, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already there (e.g. shiny) so it is not a new dependency
@@ -9,3 +9,103 @@ get_bs_version <- function() { | |||
"3" | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already a code base
TODO |
I will think in the morning if the separate Block for SHow R code make sense. |
Signed-off-by: Maciej Nasinski <nasinski.maciej@gmail.com>
I will split it to separate PRs. |
closes #85
closes #131
I join these two issues as they are connected with the same design decision, e.g. how to identify the r code text block.
150 lines net code added where 100 is a copy paste of panel_item from teal.widgets. panel_item is not exported.
panel_item
which is the biggest code part here is a copy paste from teal.widgets, will work for all Bootstrap versions.any_rcode_fun
function). This decision has some pros and cons, now we are able to control download button directly but there is additional ui part rendered on the server side. More than that thereporter_previewer_ui
function is simplified because of it, in my opinion depreciate of its arguments is not needed as they are optional and probably not yet used.Still the general design is a target, so no additional ui input when no show r code is there
Screen.Recording.2022-10-27.at.09.51.56.mov