Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of buttons in modals #186

Merged
merged 1 commit into from
May 19, 2023
+7 −6
Merged

Change color of buttons in modals #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

### Enhancements

* Changed modal button colors to align with their purpose and with other modals.
* Updated the `AddCardModule` comment input to have an active cursor when adding a card.
* Updated report previewer to support preview of multiline comment.
* Added support for a table of contents for reporter documents.
Expand Down
2 changes: 1 addition & 1 deletion R/AddCardModule.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ add_card_button_srv <- function(id, reporter, card_fun) {
footer = shiny::div(
shiny::tags$button(
type = "button",
class = "btn btn-danger",
class = "btn btn-secondary",
`data-dismiss` = "modal",
`data-bs-dismiss` = "modal",
NULL,
Expand Down
2 changes: 1 addition & 1 deletion R/DownloadModule.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ download_report_button_srv <- function(id,
footer = shiny::tagList(
shiny::tags$button(
type = "button",
class = "btn btn-danger",
class = "btn btn-secondary",
`data-dismiss` = "modal",
`data-bs-dismiss` = "modal",
NULL,
Expand Down
4 changes: 2 additions & 2 deletions R/Previewer.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@ reporter_previewer_srv <- function(id,
footer = shiny::tagList(
shiny::tags$button(
type = "button",
class = "btn btn-danger",
class = "btn btn-secondary",
`data-dismiss` = "modal",
`data-bs-dismiss` = "modal",
NULL,
"Cancel"
),
shiny::actionButton(ns("remove_card_ok"), "OK", class = "btn-warning")
shiny::actionButton(ns("remove_card_ok"), "OK", class = "btn-danger")
)
)
)
Expand Down
4 changes: 2 additions & 2 deletions R/ResetModule.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ reset_report_button_srv <- function(id, reporter) {
footer = shiny::tagList(
shiny::tags$button(
type = "button",
class = "btn btn-danger",
class = "btn btn-secondary",
`data-dismiss` = "modal",
`data-bs-dismiss` = "modal",
NULL,
"Cancel"
),
shiny::actionButton(ns("reset_reporter_ok"), "Reset", class = "btn-warning")
shiny::actionButton(ns("reset_reporter_ok"), "Reset", class = "btn-danger")
)
)
)
Expand Down