Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

212 fixing r-code formating #216

Merged
merged 96 commits into from
Sep 29, 2023
Merged

212 fixing r-code formating #216

merged 96 commits into from
Sep 29, 2023

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Sep 19, 2023 •
edited
Loading

Pull Request

fixes #212

Sample output generated from code.
report_230919205651.zip
input_20230919205655718.pptx

averissimo and others added 30 commits September 1, 2023 15:08
@averissimo
docs: add minimal version of deps
0c6c097
@averissimo
fix: ggplot2 needs to be bumped higher due to a dependency
1877d51
@averissimo
fix: zip and shinyWidgets need to be bumped higher
1e6f3fa
@averissimo
doc: corrects NEWS after rebase
ea981fe
@averissimo
docs: remove old working branch
b78f92f
@averissimo
ci: remove push on branch to prepare merge
49fb444
updating utils function to convert it into flextable.
b3fbfce
updating utils function for flextable.
c0b3a4a
updating description.
602a568
merge back from main
4bdf620 
Merge branch 'main' into 185_fixing_formating@main

# Conflicts:
#	DESCRIPTION
resolved conflict with description
65e395b
@kartikeyakirar
Merge 65e395b into 55e890a
c204d8e
@github-actions
[skip actions] Restyle files
1e1f3fb
add reverse_yaml_field function to extract report type
2ad9352
Merge branch '185_fixing_formating@main' of https://github.com/insigh…
d0029ab 
…tsengineering/teal.reporter into 185_fixing_formating@main
reversing code split logic
861ccc1
@kartikeyakirar
Merge 861ccc1 into 55e890a
ec29177
@github-actions
[skip actions] Restyle files
19bf333
updating test and fixing linter
4f04939
removing duplicate news due to merge issue.
f9fea46
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
92df034
updating Rd and fixing test
ca455be
blank commit
c9f5e69 
Merge branch '185_fixing_formating@main' of https://github.com/insightsengineering/teal.reporter into 185_fixing_formating@main

# Conflicts:
#	man/to_flextable.Rd
removing magritter dependencies
a1d97b2
added custom theme
a6d2e2a
@kartikeyakirar
Merge a6d2e2a into 55e890a
95d5a49
@github-actions
[skip actions] Restyle files
945c377
Empty-Commit
221abdd
merge back from main
7d935b0 
Merge branch 'main' into 185_fixing_formating@main

# Conflicts:
#	NEWS.md
fixing preview
5f6fc66
chlebowa
chlebowa suggested changes Sep 26, 2023
View reviewed changes
R/Renderer.R Outdated Show resolved Hide resolved
R/Renderer.R Outdated Show resolved Hide resolved
R/Renderer.R Outdated Show resolved Hide resolved
R/yaml_utils.R Outdated Show resolved Hide resolved
R/yaml_utils.R Outdated Show resolved Hide resolved
R/yaml_utils.R Outdated Show resolved Hide resolved
R/yaml_utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
@kartikeyakirar kartikeyakirar mentioned this pull request Sep 27, 2023
Merged
merge back from main
6076746 
Merge branch 'main' into 212_rocde_formating@185_fixing_formating@main

# Conflicts:
#	R/utils.R
@kartikeyakirar kartikeyakirar requested a review from a team September 28, 2023 09:26
chlebowa
chlebowa suggested changes Sep 28, 2023
View reviewed changes
R/yaml_utils.R Outdated Show resolved Hide resolved
R/Renderer.R Outdated Show resolved Hide resolved
chlebowa
chlebowa reviewed Sep 28, 2023
View reviewed changes
R/Renderer.R Outdated Show resolved Hide resolved
chlebowa
chlebowa reviewed Sep 28, 2023
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
chlebowa
chlebowa suggested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix testthat functions to adhere to the convention we use in other packages.

tests/testthat/test-utils.R Outdated Show resolved Hide resolved
@kartikeyakirar kartikeyakirar enabled auto-merge (squash) September 29, 2023 11:01
@kartikeyakirar kartikeyakirar merged commit 6165a24 into main Sep 29, 2023
23 checks passed
@kartikeyakirar kartikeyakirar deleted the 212_rocde_formating@185_fixing_formating@main branch September 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlebowa chlebowa chlebowa approved these changes

@donyunardi donyunardi Awaiting requested review from donyunardi

@averissimo averissimo Awaiting requested review from averissimo

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Rcode formating in PPT outputs
3 participants
@kartikeyakirar @averissimo @chlebowa