Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set to release #264

Merged
merged 3 commits into from
Mar 19, 2024
Merged

set to release #264

merged 3 commits into from
Mar 19, 2024

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Mar 15, 2024

Fixes #256

Issue reported on CRAN is reproducible also on our insightsengineering image (see here).
Current commit doesn't fail on the same image.

Copy link
Contributor

github-actions bot commented Mar 15, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/AddCardModule.R       144       2  98.61%   165, 202
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         18       2  88.89%   57-63
R/DownloadModule.R      209      49  76.56%   98-104, 147, 179-184, 193-197, 200-204, 212-216, 219-223, 230-234, 237-241, 280-284
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       2  93.33%   20, 118
R/Previewer.R           297      56  81.14%   199, 215, 217-220, 223, 226-234, 348-392
R/RcodeBlock.R           15       0  100.00%
R/Renderer.R            113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R           77       4  94.81%   192, 233, 238, 259
R/Reporter.R             94       1  98.94%   270
R/ResetModule.R          55       0  100.00%
R/SimpleReporter.R       30       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R               171      80  53.22%   7, 38-97, 99, 102-109, 167, 179-181, 285-294
R/yaml_utils.R           81       2  97.53%   79, 290
R/zzz.R                  14      10  28.57%   2-13, 19
TOTAL                  1410     245  82.62%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bf70422

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Unit Tests Summary

  1 files   18 suites   11s ⏱️
204 tests 204 ✅ 0 💤 0 ❌
346 runs  346 ✅ 0 💤 0 ❌

Results for commit bf70422.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Mar 15, 2024
@gogonzo
Copy link
Contributor Author

gogonzo commented Mar 15, 2024

Package went through first round of tests successfully - submitted to CRAN. Fingers crossed it doesn't fail for the same reason 👍

@gogonzo
Copy link
Contributor Author

gogonzo commented Mar 18, 2024

Are release tags added automatically after merge to main or anything specific needed on this branch @donyunardi

donyunardi added a commit that referenced this pull request Mar 19, 2024
This reverts commit ef1f79f and
384f941.

We need to revert these commits so that we can merge #264, ensuring that
we have the same content in both CRAN and GitHub tags.

We will re-revert the commits after the release.
@vedhav vedhav self-requested a review March 19, 2024 04:32
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@donyunardi donyunardi merged commit 82b79ae into main Mar 19, 2024
24 checks passed
@donyunardi donyunardi deleted the releasev0.3.1 branch March 19, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CRAN issues
3 participants