-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1290 reporter previewer buttons overlap #282
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Diff against main
Results for commit: 0512807 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 18 suites 33s ⏱️ Results for commit 0512807. ♻️ This comment has been updated with latest results. |
Current state after @vedhav improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think we can merge this without waiting for feature branch too. This is independent to the new changes in the feature branchs.
Just linted the css file as it was crazy before :) |
Fixes insightsengineering/teal#1290 as a part of insightsengineering/teal#1253
Status: currently managed to figure out application on divs on buttons so they do not overlap
Now: planning to put each button in a separate line so they do not go out of the
encodings
panel