Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1290 reporter previewer buttons overlap #282

Merged
merged 4 commits into from
Aug 14, 2024
Merged

1290 reporter previewer buttons overlap #282

merged 4 commits into from
Aug 14, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 6, 2024

Fixes insightsengineering/teal#1290 as a part of insightsengineering/teal#1253

Status: currently managed to figure out application on divs on buttons so they do not overlap
Now: planning to put each button in a separate line so they do not go out of the encodings panel

library(shiny)
library(teal.reporter)

shinyApp(
  ui = fluidPage(reporter_previewer_ui("simple")),
  server = function(input, output, session) {
    reporter_previewer_srv("simple", Reporter$new())
  }
)
image

@m7pr m7pr added the core label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@m7pr m7pr changed the title 1290 reporter previewer buttons overlap WIP 1290 reporter previewer buttons overlap Aug 6, 2024
@m7pr
Copy link
Contributor Author

m7pr commented Aug 6, 2024

I have read the CLA Document and I hereby sign the CLA

@m7pr m7pr mentioned this pull request Aug 7, 2024
63 tasks
@vedhav
Copy link
Contributor

vedhav commented Aug 7, 2024

I have read the CLA Document and I hereby sign the CLA

@vedhav vedhav marked this pull request as ready for review August 7, 2024 10:40
Copy link
Contributor

github-actions bot commented Aug 7, 2024

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0512807

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Unit Tests Summary

  1 files   18 suites   33s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 0512807.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Aug 7, 2024

Current state after @vedhav improvements

image image

Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I think we can merge this without waiting for feature branch too. This is independent to the new changes in the feature branchs.

@vedhav
Copy link
Contributor

vedhav commented Aug 7, 2024

Just linted the css file as it was crazy before :)

@m7pr m7pr changed the title WIP 1290 reporter previewer buttons overlap 1290 reporter previewer buttons overlap Aug 7, 2024
@vedhav
Copy link
Contributor

vedhav commented Aug 7, 2024

We can wait before the merge. We could have other changes and it looks like the stable version does not have this bug and only the dev version does.
image
image

@m7pr m7pr merged commit d08659f into main Aug 14, 2024
29 checks passed
@m7pr m7pr deleted the 669_insertUI@main branch August 14, 2024 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Download Report and Reset Report overlap and do not fit into encoding panel
2 participants