-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_card_button_srv - card_fun #93
Conversation
Code Coverage Summary
Results for commit: 674a4c7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments from me
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this works well - so we can unblock the tmc PR and update it if needed
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
closes #90
add_card_button_srv supports passing card_fun with any of the 2 available arguments
Now the order of arguments does not matter.