Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_card_button_srv - card_fun #93

Merged
merged 6 commits into from
Jun 30, 2022
Merged

add_card_button_srv - card_fun #93

merged 6 commits into from
Jun 30, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jun 29, 2022

closes #90
add_card_button_srv supports passing card_fun with any of the 2 available arguments

Now the order of arguments does not matter.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------------------------------------------
R/AddCardModule.R       100       3  97.00%   75-77
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      137      24  82.48%   76-78, 99, 156-160, 163-167, 174-178, 181-185
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         31       0  100.00%
R/Previewer.R           215      11  94.88%   158, 160-163, 168-174
R/Renderer.R             54       4  92.59%   142, 144-145, 166
R/ReportCard.R           30       1  96.67%   138
R/Reporter.R             43       0  100.00%
R/ResetModule.R          45       0  100.00%
R/SimpleReporter.R       18       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TealReportCard.R       12       0  100.00%
R/TextBlock.R             7       0  100.00%
R/yaml_utils.R           74       2  97.30%   65, 263
TOTAL                   793      45  94.33%

Results for commit: 674a4c7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Unit Tests Summary

    1 files    15 suites   6s ⏱️
135 tests 135 ✔️ 0 💤 0
190 runs  190 ✔️ 0 💤 0

Results for commit 34a8097.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments from me

vignettes/previewerReporter.Rmd Outdated Show resolved Hide resolved
vignettes/previewerReporter.Rmd Show resolved Hide resolved
vignettes/simpleReporter.Rmd Outdated Show resolved Hide resolved
vignettes/simpleReporter.Rmd Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/AddCardModule.R Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
Polkas and others added 2 commits June 29, 2022 15:56
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this works well - so we can unblock the tmc PR and update it if needed

NEWS.md Outdated Show resolved Hide resolved
@nikolas-burkoff nikolas-burkoff self-assigned this Jun 29, 2022
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
@Polkas Polkas merged commit 6c9a05e into main Jun 30, 2022
@Polkas Polkas deleted the 90_card_fun3@main branch June 30, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

card_fun supports additional scenario
2 participants