Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append_fs accepts a list #97

Merged
merged 7 commits into from
Jul 5, 2022
Merged

append_fs accepts a list #97

merged 7 commits into from
Jul 5, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jul 4, 2022

closes #96

append_fs in the TealReportCard accept a regular list now.

The drawback is that under yaml::as.yaml ranges are not so clear because of lack of the from/to words. Another thing is a longer printout.

Because of this too long printout we should think about sth custom.

@Polkas Polkas added the core label Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Unit Tests Summary

    1 files    17 suites   9s ⏱️
183 tests 183 ✔️ 0 💤 0
265 runs  265 ✔️ 0 💤 0

Results for commit 9aa72de.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------------------------------------------
R/AddCardModule.R       100       3  97.00%   75-77
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      137      24  82.48%   76-78, 99, 156-160, 163-167, 174-178, 181-185
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       0  100.00%
R/Previewer.R           215      11  94.88%   158, 160-163, 168-174
R/Renderer.R             54       4  92.59%   142, 144-145, 166
R/ReportCard.R           72       2  97.22%   205, 226
R/Reporter.R             96       1  98.96%   255
R/ResetModule.R          45       0  100.00%
R/SimpleReporter.R       18       0  100.00%
R/TableBlock.R            8       0  100.00%
R/TealReportCard.R       20       0  100.00%
R/TextBlock.R            13       0  100.00%
R/yaml_utils.R           74       2  97.30%   65, 263
TOTAL                   938      47  94.99%

Results for commit: 57404f3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Polkas Polkas changed the title append_fs append_fs accepts a list Jul 4, 2022
@mhallal1 mhallal1 self-assigned this Jul 4, 2022
@Polkas Polkas added the blocked label Jul 4, 2022
@Polkas
Copy link
Contributor Author

Polkas commented Jul 4, 2022

@mhallal1 I think we have to first choose the solution #96 (comment)

R/TealReportCard.R Outdated Show resolved Hide resolved
Polkas and others added 2 commits July 4, 2022 16:43
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
@Polkas Polkas merged commit 28759b4 into main Jul 5, 2022
@Polkas Polkas deleted the 96_fs@main branch July 5, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TealReportCard - append_fs should consume a simple list
2 participants